[jira] [Issue Comment Deleted] (SOLR-6246) Core fails to reload when AnalyzingInfixSuggester is used as a Suggester

["Steve Rowe (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SOLR-6246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Steve Rowe updated SOLR-6246:
-----------------------------
    Comment: was deleted

(was: Attaching patch that adds a non-recursive {{test-only}} target, works for me, including running single tests (with {{-Dtestcase=...}}) or all tests.

If you run {{ant test-only}} without first running {{ant compile-test}}, then you'll get an error like:

{noformat}
BUILD FAILED
/Users/sarowe/git/lucene-solr-6/lucene/common-build.xml:1448: The following error occurred while executing this line:
/Users/sarowe/git/lucene-solr-6/lucene/common-build.xml:985: /Users/sarowe/git/lucene-solr-6/lucene/build/core/classes/test does not exist.
{noformat}

Running {{ant compile-test test-only}} will always avoid the above error, but is almost what {{ant test}} does, and so will operate at the same (slow) speed.

If you run {{ant test-only}} from a non-module directory with a {{build.xml}} file (currently {{lucene/}}, {{solr/}}, and {{lucene/analysis/}}), you'll get an error like:

{noformat}
BUILD FAILED
/Users/sarowe/git/lucene-solr-6/lucene/build.xml:60: Target 'test-only' will not run recursively.  First change directory to the module you want to test.
{noformat}

I think it's ready to go.  Should we do this?)

> Core fails to reload when AnalyzingInfixSuggester is used as a Suggester
> ------------------------------------------------------------------------
>
>                 Key: SOLR-6246
>                 URL: https://issues.apache.org/jira/browse/SOLR-6246
>             Project: Solr
>          Issue Type: Sub-task
>          Components: SearchComponents - other
>    Affects Versions: 4.8, 4.8.1, 4.9, 5.0, 5.1, 5.2, 5.3, 5.4
>            Reporter: Varun Thacker
>         Attachments: SOLR-6246.patch, SOLR-6246-test.patch, SOLR-6246-test.patch, SOLR-6246-test.patch, SOLR-6246-test.patch
>
>
> LUCENE-5477 - added near-real-time suggest building to AnalyzingInfixSuggester. One of the changes that went in was a writer is persisted now to support real time updates via the add() and update() methods.
> When we call Solr's reload command, a new instance of AnalyzingInfixSuggester is created. When trying to create a new writer on the same Directory a lock cannot be obtained and Solr fails to reload the core.
> Also when AnalyzingInfixLookupFactory throws a RuntimeException we should pass along the original message.
> I am not sure what should be the approach to fix it. Should we have a reloadHook where we close the writer?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org