You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/10/23 21:40:56 UTC
[GitHub] [incubator-tvm] tkonolige opened a new pull request #6746: [FIX,PYLINT] Fix pylint errors on MacOS with Python 3.8
tkonolige opened a new pull request #6746:
URL: https://github.com/apache/incubator-tvm/pull/6746
These errors do not seem to show up in CI, but they show up locally.
@areusch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen commented on pull request #6746: [FIX,PYLINT] Fix pylint errors on MacOS with Python 3.8
Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #6746:
URL: https://github.com/apache/incubator-tvm/pull/6746#issuecomment-715918992
I think we can merge this case, as the changes are not incompatible to the ci-lint. And will likely help when we upgrade the ci-lint's pylint version in the future
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] areusch commented on pull request #6746: [FIX,PYLINT] Fix pylint errors on MacOS with Python 3.8
Posted by GitBox <gi...@apache.org>.
areusch commented on pull request #6746:
URL: https://github.com/apache/incubator-tvm/pull/6746#issuecomment-715651918
I think this one we should potentially not merge. the reason is: I think we should keep ci-lint as the source of truth for which things are lint errors and which are not. open to be convinced otherwise, though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] jroesch merged pull request #6746: [FIX,PYLINT] Fix pylint errors on MacOS with Python 3.8
Posted by GitBox <gi...@apache.org>.
jroesch merged pull request #6746:
URL: https://github.com/apache/incubator-tvm/pull/6746
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org