You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2020/12/22 19:46:55 UTC

[kudu-CR] [thirpdarty] Upgrade to gperftools 2.8.1 

Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16897


Change subject: [thirpdarty] Upgrade to gperftools 2.8.1
......................................................................

[thirpdarty] Upgrade to gperftools 2.8.1

gperftools 2.8.0 had a new feature that lead to crashes and corruption
which was reverted in 2.8.1. This patch upgrades to 2.8.1 to avoid any
issues.

Change-Id: I69f3405d14c4a853d8c224b8111fef5961ea34dc
---
M thirdparty/download-thirdparty.sh
D thirdparty/patches/gperftools-osx-arm64.patch
2 files changed, 0 insertions(+), 22 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/97/16897/1
-- 
To view, visit http://gerrit.cloudera.org:8080/16897
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I69f3405d14c4a853d8c224b8111fef5961ea34dc
Gerrit-Change-Number: 16897
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>

[kudu-CR] [thirpdarty] Upgrade to gperftools 2.8.1

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16897 )

Change subject: [thirpdarty] Upgrade to gperftools 2.8.1
......................................................................

[thirpdarty] Upgrade to gperftools 2.8.1

gperftools 2.8.0 had a new feature that lead to crashes and corruption
which was reverted in 2.8.1. This patch upgrades to 2.8.1 to avoid any
issues.

One of the issues that is fixed via feature revert in 2.8.1 is
https://github.com/gperftools/gperftools/issues/1204

Change-Id: I69f3405d14c4a853d8c224b8111fef5961ea34dc
Reviewed-on: http://gerrit.cloudera.org:8080/16897
Reviewed-by: Bankim Bhavsar <ba...@cloudera.com>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Kudu Jenkins
---
M thirdparty/download-thirdparty.sh
D thirdparty/patches/gperftools-osx-arm64.patch
M thirdparty/vars.sh
3 files changed, 1 insertion(+), 23 deletions(-)

Approvals:
  Bankim Bhavsar: Looks good to me, approved
  Alexey Serbin: Looks good to me, approved
  Kudu Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/16897
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I69f3405d14c4a853d8c224b8111fef5961ea34dc
Gerrit-Change-Number: 16897
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [thirpdarty] Upgrade to gperftools 2.8.1

Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16897 )

Change subject: [thirpdarty] Upgrade to gperftools 2.8.1
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/16897
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I69f3405d14c4a853d8c224b8111fef5961ea34dc
Gerrit-Change-Number: 16897
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 23 Dec 2020 17:38:40 +0000
Gerrit-HasComments: No

[kudu-CR] [thirpdarty] Upgrade to gperftools 2.8.1

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16897 )

Change subject: [thirpdarty] Upgrade to gperftools 2.8.1
......................................................................


Patch Set 3: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/16897/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/16897/2//COMMIT_MSG@9
PS2, Line 9: rashes and corruption
           : which was reverted in 2.8.1
> Done
Thank you!



-- 
To view, visit http://gerrit.cloudera.org:8080/16897
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I69f3405d14c4a853d8c224b8111fef5961ea34dc
Gerrit-Change-Number: 16897
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 23 Dec 2020 17:49:01 +0000
Gerrit-HasComments: Yes

[kudu-CR] [thirpdarty] Upgrade to gperftools 2.8.1

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16897 )

Change subject: [thirpdarty] Upgrade to gperftools 2.8.1
......................................................................


Patch Set 2:

Nice. This was probably the root cause of https://issues.apache.org/jira/browse/KUDU-3222


-- 
To view, visit http://gerrit.cloudera.org:8080/16897
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I69f3405d14c4a853d8c224b8111fef5961ea34dc
Gerrit-Change-Number: 16897
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 22 Dec 2020 19:51:48 +0000
Gerrit-HasComments: No

[kudu-CR] [thirpdarty] Upgrade to gperftools 2.8.1

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16897 )

Change subject: [thirpdarty] Upgrade to gperftools 2.8.1
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/16897
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I69f3405d14c4a853d8c224b8111fef5961ea34dc
Gerrit-Change-Number: 16897
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 22 Dec 2020 21:46:04 +0000
Gerrit-HasComments: No

[kudu-CR] [thirpdarty] Upgrade to gperftools 2.8.1

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16897 )

Change subject: [thirpdarty] Upgrade to gperftools 2.8.1
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/16897
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I69f3405d14c4a853d8c224b8111fef5961ea34dc
Gerrit-Change-Number: 16897
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 22 Dec 2020 19:51:52 +0000
Gerrit-HasComments: No

[kudu-CR] [thirpdarty] Upgrade to gperftools 2.8.1

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/16897

to look at the new patch set (#2).

Change subject: [thirpdarty] Upgrade to gperftools 2.8.1
......................................................................

[thirpdarty] Upgrade to gperftools 2.8.1

gperftools 2.8.0 had a new feature that lead to crashes and corruption
which was reverted in 2.8.1. This patch upgrades to 2.8.1 to avoid any
issues.

Change-Id: I69f3405d14c4a853d8c224b8111fef5961ea34dc
---
M thirdparty/download-thirdparty.sh
D thirdparty/patches/gperftools-osx-arm64.patch
M thirdparty/vars.sh
3 files changed, 1 insertion(+), 23 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/97/16897/2
-- 
To view, visit http://gerrit.cloudera.org:8080/16897
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I69f3405d14c4a853d8c224b8111fef5961ea34dc
Gerrit-Change-Number: 16897
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [thirpdarty] Upgrade to gperftools 2.8.1

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Bankim Bhavsar, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/16897

to look at the new patch set (#3).

Change subject: [thirpdarty] Upgrade to gperftools 2.8.1
......................................................................

[thirpdarty] Upgrade to gperftools 2.8.1

gperftools 2.8.0 had a new feature that lead to crashes and corruption
which was reverted in 2.8.1. This patch upgrades to 2.8.1 to avoid any
issues.

One of the issues that is fixed via feature revert in 2.8.1 is
https://github.com/gperftools/gperftools/issues/1204

Change-Id: I69f3405d14c4a853d8c224b8111fef5961ea34dc
---
M thirdparty/download-thirdparty.sh
D thirdparty/patches/gperftools-osx-arm64.patch
M thirdparty/vars.sh
3 files changed, 1 insertion(+), 23 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/97/16897/3
-- 
To view, visit http://gerrit.cloudera.org:8080/16897
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I69f3405d14c4a853d8c224b8111fef5961ea34dc
Gerrit-Change-Number: 16897
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [thirpdarty] Upgrade to gperftools 2.8.1

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16897 )

Change subject: [thirpdarty] Upgrade to gperftools 2.8.1
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/16897/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/16897/2//COMMIT_MSG@9
PS2, Line 9: rashes and corruption
           : which was reverted in 2.8.1
> +1
Done


http://gerrit.cloudera.org:8080/#/c/16897/2//COMMIT_MSG@9
PS2, Line 9: rashes and corruption
           : which was reverted in 2.8.1
> nit: could you add a reference to the issue in this commit message?  Andrew
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/16897
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I69f3405d14c4a853d8c224b8111fef5961ea34dc
Gerrit-Change-Number: 16897
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 23 Dec 2020 17:38:06 +0000
Gerrit-HasComments: Yes

[kudu-CR] [thirpdarty] Upgrade to gperftools 2.8.1

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16897 )

Change subject: [thirpdarty] Upgrade to gperftools 2.8.1
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/16897/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/16897/2//COMMIT_MSG@9
PS2, Line 9: rashes and corruption
           : which was reverted in 2.8.1
nit: could you add a reference to the issue in this commit message?  Andrew pointed at https://github.com/gperftools/gperftools/issues/1204

Does it make sense to add this here for posterity?



-- 
To view, visit http://gerrit.cloudera.org:8080/16897
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I69f3405d14c4a853d8c224b8111fef5961ea34dc
Gerrit-Change-Number: 16897
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 22 Dec 2020 21:46:01 +0000
Gerrit-HasComments: Yes

[kudu-CR] [thirpdarty] Upgrade to gperftools 2.8.1

Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16897 )

Change subject: [thirpdarty] Upgrade to gperftools 2.8.1
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/16897/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/16897/2//COMMIT_MSG@9
PS2, Line 9: rashes and corruption
           : which was reverted in 2.8.1
> nit: could you add a reference to the issue in this commit message?  Andrew
+1



-- 
To view, visit http://gerrit.cloudera.org:8080/16897
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I69f3405d14c4a853d8c224b8111fef5961ea34dc
Gerrit-Change-Number: 16897
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 23 Dec 2020 17:19:39 +0000
Gerrit-HasComments: Yes