You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@turbine.apache.org by "Georg Kallidis (Updated) (JIRA)" <ji...@apache.org> on 2012/02/01 17:16:58 UTC
[jira] [Updated] (TRB-88) services.VelocityService.runtime.log not
relative
[ https://issues.apache.org/jira/browse/TRB-88?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Georg Kallidis updated TRB-88:
------------------------------
Description:
The definition in TR.properties of the velocity log is
services.VelocityService.runtime.log=/log/velocity.log
If using the default class org.apache.turbine.services.velocity.TurbineVelocityService as the VelocityService the method
public ExtendedProperties createVelocityProperties(Configuration conf)
is called when the service is initialized. At the beginning this check is used:
if (!key.endsWith(RESOURCE_LOADER_PATH) {... continue }
and only after this pathes are resolved relative to the web-app.
If you consider this, then e.g defining runtime.log as above you end up (in may case) with a log in C:/log/velocity.log.
I would propose changing the line to
if (!key.endsWith(RESOURCE_LOADER_PATH) && !key.endsWith("runtime.log"))
or applying a change to make the condition check configurable ...
was:
The definition in TR.properties of the velocity log is
services.VelocityService.runtime.log=/log/velocity.log
If using the default class org.apache.turbine.services.velocity.TurbineVelocityService as the VelocityService the method
public ExtendedProperties createVelocityProperties(Configuration conf)
which is called when the service is initialized. It has at the beginning:
if (!key.endsWith(RESOURCE_LOADER_PATH) {... continue }
and only after this pathes are resolved relative to the web-app.
If you consider this, then e.g defining runtime.log as above you end up (in may case) with a log in C:/log/velocity.log.
Either change the line to
if (!key.endsWith(RESOURCE_LOADER_PATH) && !key.endsWith("runtime.log"))
or apply a change to make the condition check configurable ...
> services.VelocityService.runtime.log not relative
> -------------------------------------------------
>
> Key: TRB-88
> URL: https://issues.apache.org/jira/browse/TRB-88
> Project: Turbine
> Issue Type: Improvement
> Components: Core
> Affects Versions: Core 2.3.3
> Environment: Windows XP
> Reporter: Georg Kallidis
> Priority: Minor
>
> The definition in TR.properties of the velocity log is
> services.VelocityService.runtime.log=/log/velocity.log
> If using the default class org.apache.turbine.services.velocity.TurbineVelocityService as the VelocityService the method
> public ExtendedProperties createVelocityProperties(Configuration conf)
> is called when the service is initialized. At the beginning this check is used:
> if (!key.endsWith(RESOURCE_LOADER_PATH) {... continue }
> and only after this pathes are resolved relative to the web-app.
> If you consider this, then e.g defining runtime.log as above you end up (in may case) with a log in C:/log/velocity.log.
> I would propose changing the line to
> if (!key.endsWith(RESOURCE_LOADER_PATH) && !key.endsWith("runtime.log"))
> or applying a change to make the condition check configurable ...
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira