[GitHub] [beam] boyuanzz commented on a change in pull request #11199: [BEAM-9562] Update Timer encoding to V2

[GitBox <gi...@apache.org>]

boyuanzz commented on a change in pull request #11199: [BEAM-9562] Update Timer encoding to V2
URL: https://github.com/apache/beam/pull/11199#discussion_r397351447
 
 

 ##########
 File path: model/fn-execution/src/main/proto/beam_fn_api.proto
 ##########
 @@ -609,16 +609,20 @@ message Elements {
     // represents the producer of these timers.
     string transform_id = 2;
 
+    // (Optional) The local timer family name used to identify the associated
+    // timer family specification
+    string timer_family_tag = 3;
+
     // (Optional) The local timer name used to identify the associated timer specification.
-    string timer_id = 3;
+    string timer_id = 4;
 
     // (Optional) Represents a logical byte stream of a timer. Encoded according
     // to the coder in the timer spec.
-    bytes timer = 4;
+    bytes timer = 5;
 
 Review comment:
   The `Elements` has repeated field of `Timer`. So I think the `Timer` represents a single timer,  and `Element` represent a full stream of timers for one bundle.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services