[GitHub] [kyuubi] bowenliang123 commented on a diff in pull request #5248: [AUTHZ] Support checking previleges for Iceberg's CALL statements to system procedures

["bowenliang123 (via GitHub)" <gi...@apache.org>]

bowenliang123 commented on code in PR #5248:
URL: https://github.com/apache/kyuubi/pull/5248#discussion_r1315684686


##########
extensions/spark/kyuubi-spark-authz/src/test/scala/org/apache/kyuubi/plugin/spark/authz/gen/IcebergCommands.scala:
##########
@@ -49,10 +49,22 @@ object IcebergCommands {
     TableCommandSpec(cmd, Seq(tableDesc), queryDescs = Seq(queryDesc))
   }
 
+  val IcebergCallCommand = {
+    val cmd = "org.apache.spark.sql.catalyst.plans.logical.Call"
+    val actionTypeDesc = ActionTypeDesc(actionType = Some(INSERT))

Review Comment:
   `UPDATE` is the more proper one for the action type.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org