You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2018/11/02 22:08:32 UTC
[kudu-CR] [tools] reference comparison mode for rebalancing algo tests
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11870
Change subject: [tools] reference comparison mode for rebalancing algo tests
......................................................................
[tools] reference comparison mode for rebalancing algo tests
Introduced comparison mode for the rebalancing algorithms' tests.
There are some implementation details like using the hash (not tree)
dictionary collections and additional randomness among the moves of
equal cost in the cross-location rebalancing algorithms. In some
scenarios, when the order of the resulting moves might be different
from one run to another due to the mentioned details, it's necessary
to normalize the reference and the actual results before comparison.
Change-Id: I8363f013b5bf8caa3e3b967c64eccca95c763a91
---
M src/kudu/tools/rebalance_algo-test.cc
1 file changed, 57 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/70/11870/1
--
To view, visit http://gerrit.cloudera.org:8080/11870
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8363f013b5bf8caa3e3b967c64eccca95c763a91
Gerrit-Change-Number: 11870
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [tools] reference comparison mode for rebalancing algo tests
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Will Berkeley, Tidy Bot, Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11870
to look at the new patch set (#2).
Change subject: [tools] reference comparison mode for rebalancing algo tests
......................................................................
[tools] reference comparison mode for rebalancing algo tests
Introduced comparison mode for the rebalancing algorithms' tests.
There are some implementation details like using the hash (not tree)
dictionary collections and additional randomness among the moves of
equal cost in the cross-location rebalancing algorithms. In some
scenarios, when the order of the resulting moves might be different
from one run to another due to the mentioned details, it's necessary
to normalize the reference and the actual results before comparison.
Change-Id: I8363f013b5bf8caa3e3b967c64eccca95c763a91
---
M src/kudu/tools/rebalance_algo-test.cc
1 file changed, 59 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/70/11870/2
--
To view, visit http://gerrit.cloudera.org:8080/11870
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8363f013b5bf8caa3e3b967c64eccca95c763a91
Gerrit-Change-Number: 11870
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [tools] reference comparison mode for rebalancing algo tests
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11870 )
Change subject: [tools] reference comparison mode for rebalancing algo tests
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11870
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8363f013b5bf8caa3e3b967c64eccca95c763a91
Gerrit-Change-Number: 11870
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Tue, 06 Nov 2018 21:55:15 +0000
Gerrit-HasComments: No
[kudu-CR] [tools] reference comparison mode for rebalancing algo tests
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11870 )
Change subject: [tools] reference comparison mode for rebalancing algo tests
......................................................................
[tools] reference comparison mode for rebalancing algo tests
Introduced comparison mode for rebalancing algorithms' tests.
For current rebalancing algorithms, it's natural to re-order contiguous
moves of the same weight. That's because of:
* Iterating over elements of a hash container keyed by
the weight of a move.
* Randomly choosing among multiple options of the same weight.
This patch adds MovesOrderingComparison::IGNORE option into one test
configuration of the RebalanceAlgoUnitTest.LocationBalancingSimpleST
scenario. That fixes the breakage of the test on Ubuntu 18.
Change-Id: I8363f013b5bf8caa3e3b967c64eccca95c763a91
Reviewed-on: http://gerrit.cloudera.org:8080/11870
Tested-by: Kudu Jenkins
Reviewed-by: Will Berkeley <wd...@gmail.com>
---
M src/kudu/tools/rebalance_algo-test.cc
1 file changed, 60 insertions(+), 5 deletions(-)
Approvals:
Kudu Jenkins: Verified
Will Berkeley: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/11870
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8363f013b5bf8caa3e3b967c64eccca95c763a91
Gerrit-Change-Number: 11870
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [tools] reference comparison mode for rebalancing algo tests
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Will Berkeley, Tidy Bot, Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11870
to look at the new patch set (#3).
Change subject: [tools] reference comparison mode for rebalancing algo tests
......................................................................
[tools] reference comparison mode for rebalancing algo tests
Introduced comparison mode for rebalancing algorithms' tests.
For current rebalancing algorithms, it's natural to re-order contiguous
moves of the same weight. That's because of:
* Iterating over elements of a hash container keyed by
the weight of a move.
* Randomly choosing among multiple options of the same weight.
This patch adds MovesOrderingComparison::IGNORE option into one test
configuration of the RebalanceAlgoUnitTest.LocationBalancingSimpleST
scenario. That fixes the breakage of the test on Ubuntu 18.
Change-Id: I8363f013b5bf8caa3e3b967c64eccca95c763a91
---
M src/kudu/tools/rebalance_algo-test.cc
1 file changed, 60 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/70/11870/3
--
To view, visit http://gerrit.cloudera.org:8080/11870
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8363f013b5bf8caa3e3b967c64eccca95c763a91
Gerrit-Change-Number: 11870
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>