[jira] [Commented] (MESOS-2800) Rename Option::get(const T& _t) to getOrElse() and refactor the original function

["Marco Massenzio (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-2800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14574678#comment-14574678 ] 

Marco Massenzio commented on MESOS-2800:
----------------------------------------

[~jvanremoortere] can you please review and comment on this one, considering your recent refactorings?

thanks!

> Rename Option<T>::get(const T& _t) to getOrElse() and refactor the original function
> ------------------------------------------------------------------------------------
>
>                 Key: MESOS-2800
>                 URL: https://issues.apache.org/jira/browse/MESOS-2800
>             Project: Mesos
>          Issue Type: Improvement
>          Components: stout
>            Reporter: Mark Wang
>            Assignee: Mark Wang
>            Priority: Minor
>              Labels: newbie
>
> As suggested, if we want to change the name then we should refactor the original function as opposed to having 2 copies. 
> If we did have 2 versions of the same function, would it make more sense to delegate one of them to the other.
> As of today, there is only one file need to be refactor: 3rdparty/libprocess/3rdparty/stout/include/stout/os/osx.hpp at line 151, 161



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)