You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Owen O'Malley (JIRA)" <ji...@apache.org> on 2007/07/20 19:42:06 UTC
[jira] Created: (HADOOP-1643) make the JobSubmissionProtocol
package-local instead of public
make the JobSubmissionProtocol package-local instead of public
--------------------------------------------------------------
Key: HADOOP-1643
URL: https://issues.apache.org/jira/browse/HADOOP-1643
Project: Hadoop
Issue Type: Bug
Components: mapred
Reporter: Owen O'Malley
Assignee: Owen O'Malley
Fix For: 0.15.0
Making the JobSubmissionProtocol public was a mistake. All clients should go through JobClient to submit jobs. If there is missing functionality, we should push it into JobClient. Currently any time the protocol changes, it breaks Pig and any other direct users.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-1643) make the JobSubmissionProtocol
package-local instead of public
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12514260 ]
Owen O'Malley commented on HADOOP-1643:
---------------------------------------
This was done in HADOOP-618.
> make the JobSubmissionProtocol package-local instead of public
> --------------------------------------------------------------
>
> Key: HADOOP-1643
> URL: https://issues.apache.org/jira/browse/HADOOP-1643
> Project: Hadoop
> Issue Type: Bug
> Components: mapred
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Fix For: 0.15.0
>
>
> Making the JobSubmissionProtocol public was a mistake. All clients should go through JobClient to submit jobs. If there is missing functionality, we should push it into JobClient. Currently any time the protocol changes, it breaks Pig and any other direct users.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-1643) make the JobSubmissionProtocol
package-local instead of public
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12514261 ]
Doug Cutting commented on HADOOP-1643:
--------------------------------------
+1 When there's critical client-side functionality, the RPC protocol should generally not be public. If we someday intend to support multiple clients, then we should either have all clients in the Hadoop core (so that they can be maintained and tested as the protocol changes) or we should explicitly test the protocol independent of any client. But, for now, both of those are outside Hadoop's scope. Currently the only supported way to submit a job is with JobClient, so JobSubmissionProtocol should be package-private.
> make the JobSubmissionProtocol package-local instead of public
> --------------------------------------------------------------
>
> Key: HADOOP-1643
> URL: https://issues.apache.org/jira/browse/HADOOP-1643
> Project: Hadoop
> Issue Type: Bug
> Components: mapred
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Fix For: 0.15.0
>
>
> Making the JobSubmissionProtocol public was a mistake. All clients should go through JobClient to submit jobs. If there is missing functionality, we should push it into JobClient. Currently any time the protocol changes, it breaks Pig and any other direct users.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-1643) make the JobSubmissionProtocol
package-local instead of public
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12514263 ]
Doug Cutting commented on HADOOP-1643:
--------------------------------------
> This was done in HADOOP-618.
Mea culpa.
> make the JobSubmissionProtocol package-local instead of public
> --------------------------------------------------------------
>
> Key: HADOOP-1643
> URL: https://issues.apache.org/jira/browse/HADOOP-1643
> Project: Hadoop
> Issue Type: Bug
> Components: mapred
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Fix For: 0.15.0
>
>
> Making the JobSubmissionProtocol public was a mistake. All clients should go through JobClient to submit jobs. If there is missing functionality, we should push it into JobClient. Currently any time the protocol changes, it breaks Pig and any other direct users.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.