You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "jgillick (via GitHub)" <gi...@apache.org> on 2023/06/26 19:11:31 UTC
[GitHub] [superset] jgillick opened a new pull request, #24519: Fix:(SqlLab) correct setting name from DISPLAY_MAX_ROWS to DISPLAY_MAX_ROW
jgillick opened a new pull request, #24519:
URL: https://github.com/apache/superset/pull/24519
### SUMMARY
The warning message when results are truncated references the wrong config setting: `DISPLAY_MAX_ROWS` (plural)
### TESTING INSTRUCTIONS
* Run a query that returns more than the default row limit.
* The warning should display the correct config setting: `DISPLAY_MAX_ROW`
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina merged pull request #24519: fix: SQL Lab - correct setting name from DISPLAY_MAX_ROWS to DISPLAY_MAX_ROW
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina merged PR #24519:
URL: https://github.com/apache/superset/pull/24519
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #24519: Fix:(SqlLab) correct setting name from DISPLAY_MAX_ROWS to DISPLAY_MAX_ROW
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #24519:
URL: https://github.com/apache/superset/pull/24519#issuecomment-1609927516
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24519?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#24519](https://app.codecov.io/gh/apache/superset/pull/24519?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (2b80c3c) into [master](https://app.codecov.io/gh/apache/superset/commit/036294a1910ad777307ce7c252625b0fefdfa4d8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (036294a) will **decrease** coverage by `10.86%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 2b80c3c differs from pull request most recent head 7f9cda7. Consider uploading reports for the commit 7f9cda7 to get more accurate results
```diff
@@ Coverage Diff @@
## master #24519 +/- ##
===========================================
- Coverage 69.07% 58.22% -10.86%
===========================================
Files 1902 1902
Lines 74024 74024
Branches 8117 8117
===========================================
- Hits 51134 43099 -8035
- Misses 20779 28814 +8035
Partials 2111 2111
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `53.89% <ø> (ø)` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `53.79% <ø> (ø)` | |
| python | `60.90% <ø> (-22.59%)` | :arrow_down: |
| sqlite | `?` | |
| unit | `54.65% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/superset/pull/24519?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...frontend/src/SqlLab/components/ResultSet/index.tsx](https://app.codecov.io/gh/apache/superset/pull/24519?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC9pbmRleC50c3g=) | `63.05% <ø> (ø)` | |
... and [301 files with indirect coverage changes](https://app.codecov.io/gh/apache/superset/pull/24519/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] john-bodley commented on pull request #24519: Fix:(SqlLab) correct setting name from DISPLAY_MAX_ROWS to DISPLAY_MAX_ROW
Posted by "john-bodley (via GitHub)" <gi...@apache.org>.
john-bodley commented on PR #24519:
URL: https://github.com/apache/superset/pull/24519#issuecomment-1609913378
Thanks @jgillick for the fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org