You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tuscany.apache.org by "Kaushik Mukherjee (JIRA)" <de...@tuscany.apache.org> on 2009/02/24 01:00:02 UTC
[jira] Created: (TUSCANY-2867) Checked Exceptions are thrown as
ServiceRuntimeExceptions over non-default wireformats
Checked Exceptions are thrown as ServiceRuntimeExceptions over non-default wireformats
--------------------------------------------------------------------------------------
Key: TUSCANY-2867
URL: https://issues.apache.org/jira/browse/TUSCANY-2867
Project: Tuscany
Issue Type: Bug
Components: Java SCA JMS Binding Extension
Reporter: Kaushik Mukherjee
All exceptions are thrown as ServiceRuntimeExceptions over the non-default wireformats. We've added a patch that returns an InvocationTargetException for all checked exceptions in AbstractMessageProcessor. For the object wireformat, we felt that we should not require a boolean property in order to handle exceptions and overrode this behavior in the ObjectMessageProcessor. For the other wireformats it seemed reasonable to check for the property so we did not have to check for an instanceof ObjectMessage on every call.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TUSCANY-2867) Checked Exceptions are thrown as
ServiceRuntimeExceptions over non-default wireformats
Posted by "Simon Laws (JIRA)" <de...@tuscany.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-2867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12676678#action_12676678 ]
Simon Laws commented on TUSCANY-2867:
-------------------------------------
Thanks for the patch Kaushik. I've commited it at revision: 747826 . I'll leave this open for a little while. I'd like to remove the fault flag in the object type message. It doesn't specifically do any harm but want to discuss with you first.
> Checked Exceptions are thrown as ServiceRuntimeExceptions over non-default wireformats
> --------------------------------------------------------------------------------------
>
> Key: TUSCANY-2867
> URL: https://issues.apache.org/jira/browse/TUSCANY-2867
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA JMS Binding Extension
> Reporter: Kaushik Mukherjee
> Assignee: Simon Laws
> Attachments: TUSCANY-2867.patch
>
>
> All exceptions are thrown as ServiceRuntimeExceptions over the non-default wireformats. We've added a patch that returns an InvocationTargetException for all checked exceptions in AbstractMessageProcessor. For the object wireformat, we felt that we should not require a boolean property in order to handle exceptions and overrode this behavior in the ObjectMessageProcessor. For the other wireformats it seemed reasonable to check for the property so we did not have to check for an instanceof ObjectMessage on every call.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (TUSCANY-2867) Checked Exceptions are thrown as
ServiceRuntimeExceptions over non-default wireformats
Posted by "Simon Laws (JIRA)" <de...@tuscany.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-2867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Simon Laws reassigned TUSCANY-2867:
-----------------------------------
Assignee: Simon Laws
> Checked Exceptions are thrown as ServiceRuntimeExceptions over non-default wireformats
> --------------------------------------------------------------------------------------
>
> Key: TUSCANY-2867
> URL: https://issues.apache.org/jira/browse/TUSCANY-2867
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA JMS Binding Extension
> Reporter: Kaushik Mukherjee
> Assignee: Simon Laws
> Attachments: TUSCANY-2867.patch
>
>
> All exceptions are thrown as ServiceRuntimeExceptions over the non-default wireformats. We've added a patch that returns an InvocationTargetException for all checked exceptions in AbstractMessageProcessor. For the object wireformat, we felt that we should not require a boolean property in order to handle exceptions and overrode this behavior in the ObjectMessageProcessor. For the other wireformats it seemed reasonable to check for the property so we did not have to check for an instanceof ObjectMessage on every call.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TUSCANY-2867) Checked Exceptions are thrown as
ServiceRuntimeExceptions over non-default wireformats
Posted by "Kaushik Mukherjee (JIRA)" <de...@tuscany.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-2867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kaushik Mukherjee updated TUSCANY-2867:
---------------------------------------
Attachment: TUSCANY-2867.patch
Patch for checked exceptions over non-default wireformats:
Modified files include:
org.apache.tuscany.sca.binding.jms.provider.AbstractMessageProcessor
org.apache.tuscany.sca.binding.jms.provider.ObjectMessageProcessor
org.apache.tuscany.sca.binding.jms.wireformat.jmsbytes.runtime.WireFormatJMSBytesReferenceInterceptor
org.apache.tuscany.sca.binding.jms.wireformat.jmsobject.runtime.WireFormatJMSObjectReferenceInterceptor
org.apache.tuscany.sca.binding.jms.wireformat.jmstext.runtime.WireFormatJMSTextReferenceInterceptor
> Checked Exceptions are thrown as ServiceRuntimeExceptions over non-default wireformats
> --------------------------------------------------------------------------------------
>
> Key: TUSCANY-2867
> URL: https://issues.apache.org/jira/browse/TUSCANY-2867
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA JMS Binding Extension
> Reporter: Kaushik Mukherjee
> Attachments: TUSCANY-2867.patch
>
>
> All exceptions are thrown as ServiceRuntimeExceptions over the non-default wireformats. We've added a patch that returns an InvocationTargetException for all checked exceptions in AbstractMessageProcessor. For the object wireformat, we felt that we should not require a boolean property in order to handle exceptions and overrode this behavior in the ObjectMessageProcessor. For the other wireformats it seemed reasonable to check for the property so we did not have to check for an instanceof ObjectMessage on every call.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TUSCANY-2867) Checked Exceptions are thrown as
ServiceRuntimeExceptions over non-default wireformats
Posted by "Simon Laws (JIRA)" <de...@tuscany.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-2867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12676640#action_12676640 ]
Simon Laws commented on TUSCANY-2867:
-------------------------------------
You don't now rely on the boolean fault flag in the message when extracting faults from Object type messages. However the ObjectMessageProcessor doesn't override the createFaultMessage operation so the flag is still added to Object type messages. Is that OK for you?
Simon
> Checked Exceptions are thrown as ServiceRuntimeExceptions over non-default wireformats
> --------------------------------------------------------------------------------------
>
> Key: TUSCANY-2867
> URL: https://issues.apache.org/jira/browse/TUSCANY-2867
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA JMS Binding Extension
> Reporter: Kaushik Mukherjee
> Assignee: Simon Laws
> Attachments: TUSCANY-2867.patch
>
>
> All exceptions are thrown as ServiceRuntimeExceptions over the non-default wireformats. We've added a patch that returns an InvocationTargetException for all checked exceptions in AbstractMessageProcessor. For the object wireformat, we felt that we should not require a boolean property in order to handle exceptions and overrode this behavior in the ObjectMessageProcessor. For the other wireformats it seemed reasonable to check for the property so we did not have to check for an instanceof ObjectMessage on every call.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (TUSCANY-2867) Checked Exceptions are thrown as
ServiceRuntimeExceptions over non-default wireformats
Posted by "Simon Laws (JIRA)" <de...@tuscany.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-2867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Simon Laws resolved TUSCANY-2867.
---------------------------------
Resolution: Fixed
Fix Version/s: Java-SCA-Next
Well ok. I'll leave the code as is for now.
> Checked Exceptions are thrown as ServiceRuntimeExceptions over non-default wireformats
> --------------------------------------------------------------------------------------
>
> Key: TUSCANY-2867
> URL: https://issues.apache.org/jira/browse/TUSCANY-2867
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA JMS Binding Extension
> Reporter: Kaushik Mukherjee
> Assignee: Simon Laws
> Fix For: Java-SCA-Next
>
> Attachments: TUSCANY-2867.patch
>
>
> All exceptions are thrown as ServiceRuntimeExceptions over the non-default wireformats. We've added a patch that returns an InvocationTargetException for all checked exceptions in AbstractMessageProcessor. For the object wireformat, we felt that we should not require a boolean property in order to handle exceptions and overrode this behavior in the ObjectMessageProcessor. For the other wireformats it seemed reasonable to check for the property so we did not have to check for an instanceof ObjectMessage on every call.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TUSCANY-2867) Checked Exceptions are thrown as
ServiceRuntimeExceptions over non-default wireformats
Posted by "Kaushik Mukherjee (JIRA)" <de...@tuscany.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-2867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12676695#action_12676695 ]
Kaushik Mukherjee commented on TUSCANY-2867:
--------------------------------------------
I believe we are okay setting the fault flag even though we are not relying on it any more. I would still vote to leave the flag in place for Object types in case a non-tuscany consumer of the response finds it helpful to look at the property.
> Checked Exceptions are thrown as ServiceRuntimeExceptions over non-default wireformats
> --------------------------------------------------------------------------------------
>
> Key: TUSCANY-2867
> URL: https://issues.apache.org/jira/browse/TUSCANY-2867
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA JMS Binding Extension
> Reporter: Kaushik Mukherjee
> Assignee: Simon Laws
> Attachments: TUSCANY-2867.patch
>
>
> All exceptions are thrown as ServiceRuntimeExceptions over the non-default wireformats. We've added a patch that returns an InvocationTargetException for all checked exceptions in AbstractMessageProcessor. For the object wireformat, we felt that we should not require a boolean property in order to handle exceptions and overrode this behavior in the ObjectMessageProcessor. For the other wireformats it seemed reasonable to check for the property so we did not have to check for an instanceof ObjectMessage on every call.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.