You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Suresh Srinivas (JIRA)" <ji...@apache.org> on 2012/09/16 23:08:07 UTC
[jira] [Created] (HADOOP-8821) Findbugs warning
Configuration.dumpDeprecatedKeys() concatenates strings using + in a loop
Suresh Srinivas created HADOOP-8821:
---------------------------------------
Summary: Findbugs warning Configuration.dumpDeprecatedKeys() concatenates strings using + in a loop
Key: HADOOP-8821
URL: https://issues.apache.org/jira/browse/HADOOP-8821
Project: Hadoop Common
Issue Type: Bug
Affects Versions: 3.0.0
Reporter: Suresh Srinivas
Assignee: Suresh Srinivas
Priority: Trivial
Configuration.dumpDeprecatedKeys() concatenates strings using + in a loop. Instead use StringBuilder.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8821) Findbugs warning
Configuration.dumpDeprecatedKeys() concatenates strings using + in a loop
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13456700#comment-13456700 ]
Hudson commented on HADOOP-8821:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #2735 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2735/])
HADOOP-8821. Fix findbugs warning related concatenating string in a for loop in Configuration#dumpDeprecatedKeys(). Contributed by Suresh Srinivas. (Revision 1385389)
Result = SUCCESS
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1385389
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
> Findbugs warning Configuration.dumpDeprecatedKeys() concatenates strings using + in a loop
> ------------------------------------------------------------------------------------------
>
> Key: HADOOP-8821
> URL: https://issues.apache.org/jira/browse/HADOOP-8821
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 3.0.0
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Priority: Trivial
> Fix For: 3.0.0
>
> Attachments: HADOOP-8821.patch
>
>
> Configuration.dumpDeprecatedKeys() concatenates strings using + in a loop. Instead use StringBuilder.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8821) Findbugs warning
Configuration.dumpDeprecatedKeys() concatenates strings using + in a loop
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HADOOP-8821:
------------------------------------
Resolution: Fixed
Fix Version/s: 3.0.0
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Committed the patch. Thanks for the quick review Eli.
> Findbugs warning Configuration.dumpDeprecatedKeys() concatenates strings using + in a loop
> ------------------------------------------------------------------------------------------
>
> Key: HADOOP-8821
> URL: https://issues.apache.org/jira/browse/HADOOP-8821
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 3.0.0
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Priority: Trivial
> Fix For: 3.0.0
>
> Attachments: HADOOP-8821.patch
>
>
> Configuration.dumpDeprecatedKeys() concatenates strings using + in a loop. Instead use StringBuilder.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8821) Findbugs warning
Configuration.dumpDeprecatedKeys() concatenates strings using + in a loop
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13457031#comment-13457031 ]
Hudson commented on HADOOP-8821:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk #1199 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1199/])
HADOOP-8821. Fix findbugs warning related concatenating string in a for loop in Configuration#dumpDeprecatedKeys(). Contributed by Suresh Srinivas. (Revision 1385389)
Result = SUCCESS
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1385389
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
> Findbugs warning Configuration.dumpDeprecatedKeys() concatenates strings using + in a loop
> ------------------------------------------------------------------------------------------
>
> Key: HADOOP-8821
> URL: https://issues.apache.org/jira/browse/HADOOP-8821
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 3.0.0
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Priority: Trivial
> Fix For: 3.0.0
>
> Attachments: HADOOP-8821.patch
>
>
> Configuration.dumpDeprecatedKeys() concatenates strings using + in a loop. Instead use StringBuilder.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8821) Findbugs warning
Configuration.dumpDeprecatedKeys() concatenates strings using + in a loop
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13456692#comment-13456692 ]
Hadoop QA commented on HADOOP-8821:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12545349/HADOOP-8821.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common:
org.apache.hadoop.ha.TestZKFailoverController
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1477//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1477//console
This message is automatically generated.
> Findbugs warning Configuration.dumpDeprecatedKeys() concatenates strings using + in a loop
> ------------------------------------------------------------------------------------------
>
> Key: HADOOP-8821
> URL: https://issues.apache.org/jira/browse/HADOOP-8821
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 3.0.0
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Priority: Trivial
> Attachments: HADOOP-8821.patch
>
>
> Configuration.dumpDeprecatedKeys() concatenates strings using + in a loop. Instead use StringBuilder.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8821) Findbugs warning
Configuration.dumpDeprecatedKeys() concatenates strings using + in a loop
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13456981#comment-13456981 ]
Hudson commented on HADOOP-8821:
--------------------------------
Integrated in Hadoop-Hdfs-trunk #1168 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1168/])
HADOOP-8821. Fix findbugs warning related concatenating string in a for loop in Configuration#dumpDeprecatedKeys(). Contributed by Suresh Srinivas. (Revision 1385389)
Result = SUCCESS
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1385389
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
> Findbugs warning Configuration.dumpDeprecatedKeys() concatenates strings using + in a loop
> ------------------------------------------------------------------------------------------
>
> Key: HADOOP-8821
> URL: https://issues.apache.org/jira/browse/HADOOP-8821
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 3.0.0
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Priority: Trivial
> Fix For: 3.0.0
>
> Attachments: HADOOP-8821.patch
>
>
> Configuration.dumpDeprecatedKeys() concatenates strings using + in a loop. Instead use StringBuilder.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8821) Findbugs warning
Configuration.dumpDeprecatedKeys() concatenates strings using + in a loop
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13456695#comment-13456695 ]
Suresh Srinivas commented on HADOOP-8821:
-----------------------------------------
No tests added since the patch is a trivial change. The test failure is covered by HADOOP-8591.
> Findbugs warning Configuration.dumpDeprecatedKeys() concatenates strings using + in a loop
> ------------------------------------------------------------------------------------------
>
> Key: HADOOP-8821
> URL: https://issues.apache.org/jira/browse/HADOOP-8821
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 3.0.0
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Priority: Trivial
> Attachments: HADOOP-8821.patch
>
>
> Configuration.dumpDeprecatedKeys() concatenates strings using + in a loop. Instead use StringBuilder.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8821) Findbugs warning
Configuration.dumpDeprecatedKeys() concatenates strings using + in a loop
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13456698#comment-13456698 ]
Hudson commented on HADOOP-8821:
--------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #2798 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2798/])
HADOOP-8821. Fix findbugs warning related concatenating string in a for loop in Configuration#dumpDeprecatedKeys(). Contributed by Suresh Srinivas. (Revision 1385389)
Result = SUCCESS
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1385389
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
> Findbugs warning Configuration.dumpDeprecatedKeys() concatenates strings using + in a loop
> ------------------------------------------------------------------------------------------
>
> Key: HADOOP-8821
> URL: https://issues.apache.org/jira/browse/HADOOP-8821
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 3.0.0
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Priority: Trivial
> Fix For: 3.0.0
>
> Attachments: HADOOP-8821.patch
>
>
> Configuration.dumpDeprecatedKeys() concatenates strings using + in a loop. Instead use StringBuilder.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8821) Findbugs warning
Configuration.dumpDeprecatedKeys() concatenates strings using + in a loop
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HADOOP-8821:
------------------------------------
Status: Patch Available (was: Open)
> Findbugs warning Configuration.dumpDeprecatedKeys() concatenates strings using + in a loop
> ------------------------------------------------------------------------------------------
>
> Key: HADOOP-8821
> URL: https://issues.apache.org/jira/browse/HADOOP-8821
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 3.0.0
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Priority: Trivial
> Attachments: HADOOP-8821.patch
>
>
> Configuration.dumpDeprecatedKeys() concatenates strings using + in a loop. Instead use StringBuilder.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8821) Findbugs warning
Configuration.dumpDeprecatedKeys() concatenates strings using + in a loop
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13456679#comment-13456679 ]
Eli Collins commented on HADOOP-8821:
-------------------------------------
+1 pending jenkins
> Findbugs warning Configuration.dumpDeprecatedKeys() concatenates strings using + in a loop
> ------------------------------------------------------------------------------------------
>
> Key: HADOOP-8821
> URL: https://issues.apache.org/jira/browse/HADOOP-8821
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 3.0.0
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Priority: Trivial
> Attachments: HADOOP-8821.patch
>
>
> Configuration.dumpDeprecatedKeys() concatenates strings using + in a loop. Instead use StringBuilder.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8821) Findbugs warning
Configuration.dumpDeprecatedKeys() concatenates strings using + in a loop
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HADOOP-8821:
------------------------------------
Attachment: HADOOP-8821.patch
> Findbugs warning Configuration.dumpDeprecatedKeys() concatenates strings using + in a loop
> ------------------------------------------------------------------------------------------
>
> Key: HADOOP-8821
> URL: https://issues.apache.org/jira/browse/HADOOP-8821
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 3.0.0
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Priority: Trivial
> Attachments: HADOOP-8821.patch
>
>
> Configuration.dumpDeprecatedKeys() concatenates strings using + in a loop. Instead use StringBuilder.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8821) Findbugs warning
Configuration.dumpDeprecatedKeys() concatenates strings using + in a loop
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13456701#comment-13456701 ]
Hudson commented on HADOOP-8821:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #2759 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2759/])
HADOOP-8821. Fix findbugs warning related concatenating string in a for loop in Configuration#dumpDeprecatedKeys(). Contributed by Suresh Srinivas. (Revision 1385389)
Result = FAILURE
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1385389
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
> Findbugs warning Configuration.dumpDeprecatedKeys() concatenates strings using + in a loop
> ------------------------------------------------------------------------------------------
>
> Key: HADOOP-8821
> URL: https://issues.apache.org/jira/browse/HADOOP-8821
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 3.0.0
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Priority: Trivial
> Fix For: 3.0.0
>
> Attachments: HADOOP-8821.patch
>
>
> Configuration.dumpDeprecatedKeys() concatenates strings using + in a loop. Instead use StringBuilder.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira