You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/06/10 14:53:44 UTC

[GitHub] [arrow-datafusion] Jimexist opened a new pull request #539: refactor hash aggregates

Jimexist opened a new pull request #539:
URL: https://github.com/apache/arrow-datafusion/pull/539


   # Which issue does this PR close?
   
   Closes #.
   
    # Rationale for this change
   
   a small refactor to hash aggregate planning phase
   
   # What changes are included in this PR?
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   # Are there any user-facing changes?
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!--
   If there are any breaking changes to public APIs, please add the `api change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] Jimexist commented on a change in pull request #539: Refactor hash aggregates's planner building code

Posted by GitBox <gi...@apache.org>.
Jimexist commented on a change in pull request #539:
URL: https://github.com/apache/arrow-datafusion/pull/539#discussion_r649920230



##########
File path: datafusion/src/physical_plan/mod.rs
##########
@@ -343,7 +343,8 @@ pub enum Partitioning {
     RoundRobinBatch(usize),
     /// Allocate rows based on a hash of one of more expressions and the specified
     /// number of partitions
-    /// This partitioning scheme is not yet fully supported. See [ARROW-11011](https://issues.apache.org/jira/browse/ARROW-11011)
+    /// FIXME: This partitioning scheme is not yet fully supported.

Review comment:
       done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb merged pull request #539: Refactor hash aggregates's planner building code

Posted by GitBox <gi...@apache.org>.
alamb merged pull request #539:
URL: https://github.com/apache/arrow-datafusion/pull/539


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] Dandandan commented on a change in pull request #539: Refactor hash aggregates's planner building code

Posted by GitBox <gi...@apache.org>.
Dandandan commented on a change in pull request #539:
URL: https://github.com/apache/arrow-datafusion/pull/539#discussion_r649785783



##########
File path: datafusion/src/physical_plan/mod.rs
##########
@@ -343,7 +343,8 @@ pub enum Partitioning {
     RoundRobinBatch(usize),
     /// Allocate rows based on a hash of one of more expressions and the specified
     /// number of partitions
-    /// This partitioning scheme is not yet fully supported. See [ARROW-11011](https://issues.apache.org/jira/browse/ARROW-11011)
+    /// FIXME: This partitioning scheme is not yet fully supported.

Review comment:
       You can remove this comment - as the hash partitioning scheme is supported




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org