You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/09/12 22:12:20 UTC

[GitHub] [spark] srowen commented on a diff in pull request #37850: [SPARK-40142][PYTHON][SQL][FOLLOW-UP] Make pyspark.sql.functions examples self-contained (part 7, ~30 functions)

srowen commented on code in PR #37850:
URL: https://github.com/apache/spark/pull/37850#discussion_r968977663


##########
python/pyspark/sql/functions.py:
##########
@@ -5535,6 +5570,20 @@ def array_join(
 
     .. versionadded:: 2.4.0
 
+    Parameters
+    ----------
+    col : :class:`~pyspark.sql.Column` or str
+        target column to work on.
+    delimiter : str
+        delimiter to use concatanate elements

Review Comment:
   concatenate, here and below
   Also: "delimiter used to concatenate..."



##########
python/pyspark/sql/functions.py:
##########
@@ -6108,6 +6297,11 @@ def schema_of_json(json: "ColumnOrName", options: Optional[Dict[str, str]] = Non
         .. versionchanged:: 3.0
            It accepts `options` parameter to control schema inferring.
 
+    Returns
+    -------
+    :class:`~pyspark.sql.Column`
+        a string representatio of a :class:`StructType` parsed from given JSON.

Review Comment:
   typo in a few places: representatio -> representation



##########
python/pyspark/sql/functions.py:
##########
@@ -5797,6 +5915,11 @@ def array_except(col1: "ColumnOrName", col2: "ColumnOrName") -> Column:
     col2 : :class:`~pyspark.sql.Column` or str
         name of column containing array
 
+    Returns
+    -------
+    :class:`~pyspark.sql.Column`
+        an array of values from first array that is not in the second.

Review Comment:
   nit: that are not



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org