You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Ignasi Barrera <no...@github.com> on 2014/04/09 11:02:46 UTC
[jclouds-site] Added GCE to the list of providers (#74)
* Added GCE to the list of supported providers
* Highlighted the providers that are in labs.
* Added DigitalOcean and Google Cloud Platform logos to the front page.
You can merge this Pull Request by running:
git pull https://github.com/nacx/jclouds-site add-gce
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds-site/pull/74
-- Commit Summary --
* Added GCE to the list of providers
-- File Changes --
M _layouts/home.html (4)
M guides/providers.md (26)
A img/logos/digitalocean.png (0)
A img/logos/gcp.png (0)
-- Patch Links --
https://github.com/jclouds/jclouds-site/pull/74.patch
https://github.com/jclouds/jclouds-site/pull/74.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/74
Re: [jclouds-site] Added GCE to the list of providers (#74)
Posted by Andrew Phillips <no...@github.com>.
> @@ -18,7 +18,8 @@ The following is the list of providers that are supported by the jclouds API.
> ## <a id="compute"></a>ComputeService
> ### <a id="compute-providers"></a>Providers
>
> -The Maven Group ID for all supported providers below is [org.apache.jclouds.provider](http://search.maven.org/#search%7Cga%7C1%7Corg.apache.jclouds.provider)
> +The Maven Group ID for all supported providers below is [org.apache.jclouds.provider](http://search.maven.org/#search%7Cga%7C1%7Corg.apache.jclouds.provider)<br/>
> +(\*) Providers in labs are under the Maven Group ID [org.apache.jclouds.labs](http://search.maven.org/#search%7Cga%7C1%7Corg.apache.jclouds.labs)
How about just a `*`? And word this as?
The Maven Group ID for all providers below is [org.apache.jclouds.provider](...). Providers in [labs](...) (denoted by `*`) are under [org.apache.jclouds.labs](...).
Then, further down, just use `Google Compute Engine*` and `DigitalOcean*`?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/74/files#r11658015
Re: [jclouds-site] Added GCE to the list of providers (#74)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-site-pull-requests #237](https://jclouds.ci.cloudbees.com/job/jclouds-site-pull-requests/237/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/74#issuecomment-39942602
Re: [jclouds-site] Added GCE to the list of providers (#74)
Posted by Ignasi Barrera <no...@github.com>.
Yes, I'll fix the format today/tomorrow and publish the site with the changes.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/74#issuecomment-40506638
Re: [jclouds-site] Added GCE to the list of providers (#74)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-site-pull-requests #244](https://jclouds.ci.cloudbees.com/job/jclouds-site-pull-requests/244/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/74#issuecomment-40536853
Re: [jclouds-site] Added GCE to the list of providers (#74)
Posted by Andrew Phillips <no...@github.com>.
Thanks, @nacx! Just a comment about whether italics and brackets are ideal formatting for "labs" on the provider overview page.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/74#issuecomment-39968251
Re: [jclouds-site] Added GCE to the list of providers (#74)
Posted by jclouds-commentator <no...@github.com>.
Go to http://9cce29570370a995a0eb-1eca4f5bc22660915b0e74fcc2204395.r25.cf1.rackcdn.com/ to review your changes.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/74#issuecomment-39942724
Re: [jclouds-site] Added GCE to the list of providers (#74)
Posted by Ignasi Barrera <no...@github.com>.
Will format everything the same way.
Regarding the ISO code thing, the provider metadata does not define them, and by having a ooh at the code in both providers, they obtain the locations with a call to their API, but the returned Locations don't have the iso codes set (perhaps the API is not returning them), that's why I left them blank...
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/74#issuecomment-39970385
Re: [jclouds-site] Added GCE to the list of providers (#74)
Posted by Ignasi Barrera <no...@github.com>.
Merged and published the site! /cc @erjohnso
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/74#issuecomment-40610959
Re: [jclouds-site] Added GCE to the list of providers (#74)
Posted by Ignasi Barrera <no...@github.com>.
@demobox what about the `(*)`? Do you have a better idea? :)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/74#issuecomment-40533026
Re: [jclouds-site] Added GCE to the list of providers (#74)
Posted by Andrew Phillips <no...@github.com>.
> @@ -55,7 +56,7 @@ The Maven Group ID for all supported providers below is [org.apache.jclouds.prov
> <td>US-DC</td>
> </tr>
> <tr>
> - <td>DigitalOcean</td>
> + <td>DigitalOcean <em>(labs)</em></td>
> <td>digitalocean</td>
> <td></td>
No ISO code?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/74/files#r11437067
Re: [jclouds-site] Added GCE to the list of providers (#74)
Posted by jclouds-commentator <no...@github.com>.
Go to http://d590d593c13e38c6a672-73fb0cadc5d82c7905b4a4dd7f247aed.r1.cf1.rackcdn.com/ to review your changes.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/74#issuecomment-40537051
Re: [jclouds-site] Added GCE to the list of providers (#74)
Posted by Andrew Phillips <no...@github.com>.
> that's why I left them blank...
Fine, thanks for explaining!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/74#issuecomment-39972729
Re: [jclouds-site] Added GCE to the list of providers (#74)
Posted by Andrew Phillips <no...@github.com>.
> squashed the commits to prepare the merge!
Thanks, @nacx! +1 - good to go for me!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/74#issuecomment-40539672
Re: [jclouds-site] Added GCE to the list of providers (#74)
Posted by Ignasi Barrera <no...@github.com>.
Addressed comments and squashed the commits to prepare the merge!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/74#issuecomment-40536789
Re: [jclouds-site] Added GCE to the list of providers (#74)
Posted by Eric Johnson <no...@github.com>.
Thank you!
On Apr 16, 2014 8:13 AM, "Ignasi Barrera" <no...@github.com> wrote:
> Closed #74 <https://github.com/jclouds/jclouds-site/pull/74>.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/jclouds/jclouds-site/pull/74>
> .
>
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/74#issuecomment-40618433
Re: [jclouds-site] Added GCE to the list of providers (#74)
Posted by Andrew Phillips <no...@github.com>.
> just curious when this will find its way to the live site?
As far as I'm concerned, asap - thanks for asking. But it can't be merged right now as there are merge conflicts. I think @nacx will need to rebase first.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/74#issuecomment-40505226
Re: [jclouds-site] Added GCE to the list of providers (#74)
Posted by Eric Johnson <no...@github.com>.
@nacx, @demobox - just curious when this will find its way to the live site?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/74#issuecomment-40464230
Re: [jclouds-site] Added GCE to the list of providers (#74)
Posted by jclouds-commentator <no...@github.com>.
Go to http://bf70a46be1fcd9df8032-b89dc3716baeb15b10b83755486ea60f.r51.cf1.rackcdn.com/ to review your changes.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/74#issuecomment-40532948
Re: [jclouds-site] Added GCE to the list of providers (#74)
Posted by Ignasi Barrera <no...@github.com>.
> @@ -18,7 +18,8 @@ The following is the list of providers that are supported by the jclouds API.
> ## <a id="compute"></a>ComputeService
> ### <a id="compute-providers"></a>Providers
>
> -The Maven Group ID for all supported providers below is [org.apache.jclouds.provider](http://search.maven.org/#search%7Cga%7C1%7Corg.apache.jclouds.provider)
> +The Maven Group ID for all supported providers below is [org.apache.jclouds.provider](http://search.maven.org/#search%7Cga%7C1%7Corg.apache.jclouds.provider)<br/>
> +(\*) Providers in labs are under the Maven Group ID [org.apache.jclouds.labs](http://search.maven.org/#search%7Cga%7C1%7Corg.apache.jclouds.labs)
I like it!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/74/files#r11658659
Re: [jclouds-site] Added GCE to the list of providers (#74)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-site-pull-requests #243](https://jclouds.ci.cloudbees.com/job/jclouds-site-pull-requests/243/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/74#issuecomment-40532678
Re: [jclouds-site] Added GCE to the list of providers (#74)
Posted by Andrew Phillips <no...@github.com>.
> @@ -55,7 +56,7 @@ The Maven Group ID for all supported providers below is [org.apache.jclouds.prov
> <td>US-DC</td>
> </tr>
> <tr>
> - <td>DigitalOcean</td>
> + <td>DigitalOcean <em>(labs)</em></td>
We already have `(First Gen)` later which is formatting in brackets, so perhaps brackets are not the best thing here? For LoadBalancer we have `(Beta)`, also in brackets but not in italics.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/74/files#r11437028
Re: [jclouds-site] Added GCE to the list of providers (#74)
Posted by Eric Johnson <no...@github.com>.
Great! Thanks for all the work to help get us listed.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/74#issuecomment-40524224
Re: [jclouds-site] Added GCE to the list of providers (#74)
Posted by Andrew Phillips <no...@github.com>.
> @@ -18,7 +18,8 @@ The following is the list of providers that are supported by the jclouds API.
> ## <a id="compute"></a>ComputeService
> ### <a id="compute-providers"></a>Providers
>
> -The Maven Group ID for all supported providers below is [org.apache.jclouds.provider](http://search.maven.org/#search%7Cga%7C1%7Corg.apache.jclouds.provider)
> +The Maven Group ID for all supported providers below is [org.apache.jclouds.provider](http://search.maven.org/#search%7Cga%7C1%7Corg.apache.jclouds.provider)<br/>
> +Providers in *labs* are under the Maven Group ID [org.apache.jclouds.labs](http://search.maven.org/#search%7Cga%7C1%7Corg.apache.jclouds.labs)
Are italics the best formatting here? There are similar things on the page, `(Beta)` that are _not_ in italics.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/74/files#r11436918
Re: [jclouds-site] Added GCE to the list of providers (#74)
Posted by Andrew Phillips <no...@github.com>.
> @@ -85,6 +86,11 @@ The Maven Group ID for all supported providers below is [org.apache.jclouds.prov
> <td>US-CA,US-VA</td>
> </tr>
> <tr>
> + <td>Google Compute Engine <em>(labs)</em></td>
> + <td>google-compute-engine</td>
> + <td></td>
No ISO code?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/74/files#r11437074