You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/04/07 14:11:53 UTC
[GitHub] [incubator-shardingsphere] kimmking opened a new pull request
#5097: add metadata center project #MetaDataCenter-phase-2
kimmking opened a new pull request #5097: add metadata center project #MetaDataCenter-phase-2
URL: https://github.com/apache/incubator-shardingsphere/pull/5097
Changes proposed in this pull request:
- add metadata center sub project
- integrate center repository
- persist metadata to center repository
- optimize proxy bootstrap to process metadata
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #5097: add
metadata center project #MetaDataCenter-phase-2
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #5097: add metadata center project #MetaDataCenter-phase-2
URL: https://github.com/apache/incubator-shardingsphere/pull/5097#issuecomment-610713668
## Pull Request Test Coverage Report for [Build 10871](https://coveralls.io/builds/29926623)
* **10** of **42** **(23.81%)** changed or added relevant lines in **6** files are covered.
* **2** unchanged lines in **2** files lost coverage.
* Overall coverage decreased (**-0.01%**) to **57.317%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-metadatacenter/src/main/java/org/apache/shardingsphere/orchestration/core/metadatacenter/MetaDataCenterNode.java](https://coveralls.io/builds/29926623/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsharding-orchestration-core-metadatacenter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcore%2Fmetadatacenter%2FMetaDataCenterNode.java#L40) | 0 | 1 | 0.0%
| [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/schema/LogicSchema.java](https://coveralls.io/builds/29926623/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fschema%2FLogicSchema.java#L65) | 0 | 3 | 0.0%
| [sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-common/src/main/java/org/apache/shardingsphere/orchestration/core/common/CenterType.java](https://coveralls.io/builds/29926623/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsharding-orchestration-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcore%2Fcommon%2FCenterType.java#L34) | 0 | 4 | 0.0%
| [sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-metadatacenter/src/main/java/org/apache/shardingsphere/orchestration/core/metadatacenter/MetaDataCenter.java](https://coveralls.io/builds/29926623/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsharding-orchestration-core-metadatacenter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcore%2Fmetadatacenter%2FMetaDataCenter.java#L33) | 0 | 7 | 0.0%
| [sharding-proxy/sharding-proxy-bootstrap/src/main/java/org/apache/shardingsphere/shardingproxy/Bootstrap.java](https://coveralls.io/builds/29926623/source?filename=sharding-proxy%2Fsharding-proxy-bootstrap%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2FBootstrap.java#L119) | 0 | 17 | 0.0%
<!-- | **Total:** | **10** | **42** | **23.81%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/schema/LogicSchema.java](https://coveralls.io/builds/29926623/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fschema%2FLogicSchema.java#L76) | 1 | 0% |
| [sharding-proxy/sharding-proxy-bootstrap/src/main/java/org/apache/shardingsphere/shardingproxy/Bootstrap.java](https://coveralls.io/builds/29926623/source?filename=sharding-proxy%2Fsharding-proxy-bootstrap%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2FBootstrap.java#L124) | 1 | 0% |
<!-- | **Total:** | **2** | | -->
| Totals | [](https://coveralls.io/builds/29926623) |
| :-- | --: |
| Change from base [Build 10867](https://coveralls.io/builds/29910527): | -0.01% |
| Covered Lines: | 11668 |
| Relevant Lines: | 20357 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero merged pull request #5097:
add metadata center project #MetaDataCenter-phase-2
Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #5097: add metadata center project #MetaDataCenter-phase-2
URL: https://github.com/apache/incubator-shardingsphere/pull/5097
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking commented on a change in pull
request #5097: add metadata center project #MetaDataCenter-phase-2
Posted by GitBox <gi...@apache.org>.
kimmking commented on a change in pull request #5097: add metadata center project #MetaDataCenter-phase-2
URL: https://github.com/apache/incubator-shardingsphere/pull/5097#discussion_r405222766
##########
File path: sharding-orchestration/sharding-orchestration-center/sharding-orchestration-core-metadatacenter/src/main/java/org/apache/shardingsphere/orchestration/core/metadatacenter/MetaDataCenter.java
##########
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.orchestration.core.metadatacenter;
+
+import org.apache.shardingsphere.orchestration.center.CenterRepository;
+
+/**
+ * RegistryCenter hold and persist instance state.
Review comment:
It has been removed.
This commit log is not clean.
Another log is following.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] menghaoranss commented on a change in
pull request #5097: add metadata center project #MetaDataCenter-phase-2
Posted by GitBox <gi...@apache.org>.
menghaoranss commented on a change in pull request #5097: add metadata center project #MetaDataCenter-phase-2
URL: https://github.com/apache/incubator-shardingsphere/pull/5097#discussion_r405221949
##########
File path: sharding-orchestration/sharding-orchestration-center/sharding-orchestration-core-metadatacenter/src/main/java/org/apache/shardingsphere/orchestration/core/metadatacenter/MetaDataCenter.java
##########
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.orchestration.core.metadatacenter;
+
+import org.apache.shardingsphere.orchestration.center.CenterRepository;
+
+/**
+ * RegistryCenter hold and persist instance state.
Review comment:
The comment should be modified.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking commented on issue #5097: add
metadata center project #MetaDataCenter-phase-2
Posted by GitBox <gi...@apache.org>.
kimmking commented on issue #5097: add metadata center project #MetaDataCenter-phase-2
URL: https://github.com/apache/incubator-shardingsphere/pull/5097#issuecomment-610717822
I have squash 10 commits to 1 commits.
It's clean now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services