You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by aw...@apache.org on 2020/06/05 15:42:10 UTC
[fineract] branch develop updated: FINERACT-822 Enabling ErrorProne
error checks (#983)
This is an automated email from the ASF dual-hosted git repository.
awasum pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/fineract.git
The following commit(s) were added to refs/heads/develop by this push:
new cd3621c FINERACT-822 Enabling ErrorProne error checks (#983)
cd3621c is described below
commit cd3621cb6025fe2a257e90553222e628ddb2f321
Author: Percy Ayuk Ashu <pe...@gmail.com>
AuthorDate: Fri Jun 5 16:42:01 2020 +0100
FINERACT-822 Enabling ErrorProne error checks (#983)
---
fineract-provider/build.gradle | 55 ++++++++++++----------
.../savings/service/SavingsEnumerations.java | 4 +-
2 files changed, 31 insertions(+), 28 deletions(-)
diff --git a/fineract-provider/build.gradle b/fineract-provider/build.gradle
index af03680..dbaefb3 100644
--- a/fineract-provider/build.gradle
+++ b/fineract-provider/build.gradle
@@ -341,41 +341,44 @@ tasks.withType(JavaCompile) {
"MultipleTopLevelClasses",
"MultiVariableDeclaration",
"AssertEqualsArgumentOrderChecker",
+ "EmptySetMultibindingContributions",
+ "MixedArrayDimensions",
+ "PackageLocation",
+ "UseBinds",
+ "IntLongMath",
+ "FloatCast",
+ "ReachabilityFenceUsage",
+ "StreamResourceLeak",
+ "TruthIncompatibleType",
+ "ByteBufferBackingArray",
+ "OrphanedFormatString",
+ "CatchAndPrintStackTrace",
+ "ObjectToString",
+ "AssertThrowsMultipleStatements",
+ "BoxedPrimitiveConstructor",
+ "SynchronizeOnNonFinalField",
+ "WildcardImport",
+ "FutureReturnValueIgnored",
+ "PrivateConstructorForNoninstantiableModule",
+ "ClassNewInstance",
+ "UnsafeFinalization",
+ "MutableMethodReturnType",
+ "SwitchDefault",
+ "VarTypeName",
+ "ArgumentSelectionDefectChecker",
+ "CompareToZero",
+ "NarrowingCompoundAssignment",
// "ReturnMissingNullable",
// "InconsistentOverloads",
// "MethodCanBeStatic",
// "Var",
// "ConstantField",
-// "EmptySetMultibindingContributions",
-// "MixedArrayDimensions",
-// "PackageLocation",
-// "PrivateConstructorForNoninstantiableModule",
// "UnnecessaryStaticImport",
-// "UseBinds",
-// "WildcardImport",
-// "FutureReturnValueIgnored",
-// "IntLongMath",
-// "FloatCast",
-// "ClassNewInstance",
// "ConstructorInvokesOverridable",
-// "UnsafeFinalization",
-// "MutableMethodReturnType",
-// "SynchronizeOnNonFinalField",
-// "SwitchDefault",
-// "ReachabilityFenceUsage",
-// "BoxedPrimitiveConstructor",
// "InjectOnConstructorOfAbstractClass",
-//// "StringSplitter",
+// "StringSplitter",
// "UnnecessaryDefaultInEnumSwitch",
-// "StreamResourceLeak",
-//// "InconsistentCapitalization",
-// "TruthIncompatibleType",
-// "ByteBufferBackingArray",
-// "OrphanedFormatString",
-// "CatchAndPrintStackTrace",
-// "VarTypeName",
-// "ObjectToString",
-// "AssertThrowsMultipleStatements",
+// "InconsistentCapitalization",
// "FieldCanBeFinal"
)
}
diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/service/SavingsEnumerations.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/service/SavingsEnumerations.java
index b0b2644..071b2e4 100644
--- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/service/SavingsEnumerations.java
+++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/service/SavingsEnumerations.java
@@ -163,7 +163,6 @@ public class SavingsEnumerations {
optionData = new SavingsAccountTransactionEnumData(SavingsAccountTransactionType.WITHDRAW_TRANSFER.getValue().longValue(),
SavingsAccountTransactionType.WITHDRAW_TRANSFER.getCode(), "Transfer Withdrawn");
break;
- default:
case PAY_CHARGE:
optionData = new SavingsAccountTransactionEnumData(SavingsAccountTransactionType.PAY_CHARGE.getValue().longValue(),
SavingsAccountTransactionType.PAY_CHARGE.getCode(), "Pay Charge");
@@ -200,6 +199,7 @@ public class SavingsEnumerations {
optionData = new SavingsAccountTransactionEnumData(SavingsAccountTransactionType.AMOUNT_RELEASE.getValue().longValue(),
SavingsAccountTransactionType.AMOUNT_RELEASE.getCode(), "Release Amount");
break;
+ default:
}
return optionData;
}
@@ -839,4 +839,4 @@ public class SavingsEnumerations {
}
return optionData;
}
-}
\ No newline at end of file
+}