You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/01/16 15:30:00 UTC
[GitHub] [incubator-nuttx-apps] raiden00pl opened a new pull request #18:
examples/sx127x_demo/sx127x_demo.c: RX/TX only if RX/TX enabled
raiden00pl opened a new pull request #18: examples/sx127x_demo/sx127x_demo.c: RX/TX only if RX/TX enabled
URL: https://github.com/apache/incubator-nuttx-apps/pull/18
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] jerpelea commented on a change in pull
request #18: examples/sx127x_demo/sx127x_demo.c: RX/TX only if RX/TX enabled
Posted by GitBox <gi...@apache.org>.
jerpelea commented on a change in pull request #18: examples/sx127x_demo/sx127x_demo.c: RX/TX only if RX/TX enabled
URL: https://github.com/apache/incubator-nuttx-apps/pull/18#discussion_r367485974
##########
File path: examples/sx127x_demo/sx127x_demo.c
##########
@@ -541,7 +544,9 @@ int main(int argc, FAR char *argv[])
break;
}
+#endif
Review comment:
you can use a single ifdef block for both RX and TX
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] Ouss4 merged pull request #18:
examples/sx127x_demo/sx127x_demo.c: RX/TX only if RX/TX enabled
Posted by GitBox <gi...@apache.org>.
Ouss4 merged pull request #18: examples/sx127x_demo/sx127x_demo.c: RX/TX only if RX/TX enabled
URL: https://github.com/apache/incubator-nuttx-apps/pull/18
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] jerpelea commented on a change in pull
request #18: examples/sx127x_demo/sx127x_demo.c: RX/TX only if RX/TX enabled
Posted by GitBox <gi...@apache.org>.
jerpelea commented on a change in pull request #18: examples/sx127x_demo/sx127x_demo.c: RX/TX only if RX/TX enabled
URL: https://github.com/apache/incubator-nuttx-apps/pull/18#discussion_r367485974
##########
File path: examples/sx127x_demo/sx127x_demo.c
##########
@@ -541,7 +544,9 @@ int main(int argc, FAR char *argv[])
break;
}
+#endif
Review comment:
you can use a single ifdef block for both RX and TX
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx-apps] jerpelea commented on a change in pull
request #18: examples/sx127x_demo/sx127x_demo.c: RX/TX only if RX/TX enabled
Posted by GitBox <gi...@apache.org>.
jerpelea commented on a change in pull request #18: examples/sx127x_demo/sx127x_demo.c: RX/TX only if RX/TX enabled
URL: https://github.com/apache/incubator-nuttx-apps/pull/18#discussion_r367485974
##########
File path: examples/sx127x_demo/sx127x_demo.c
##########
@@ -541,7 +544,9 @@ int main(int argc, FAR char *argv[])
break;
}
+#endif
Review comment:
you can use a single ifdef block
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services