[GitHub] [incubator-doris] imay commented on a change in pull request #2782: Add file cache for v2

[GitBox <gi...@apache.org>]

imay commented on a change in pull request #2782: Add file cache for v2
URL: https://github.com/apache/incubator-doris/pull/2782#discussion_r373998213
 
 

 ##########
 File path: be/src/olap/rowset/segment_v2/indexed_column_reader.h
 ##########
 @@ -131,6 +140,10 @@ class IndexedColumnIterator {
     std::unique_ptr<ParsedPage> _data_page;
     // next_batch() will read from this position
     rowid_t _current_rowid = 0;
+    // open file handle
+    std::unique_ptr<OpenedFileHandle<RandomAccessFile>> _file_handle;
+    // file to read
+    RandomAccessFile* _file;
 
 Review comment:
   ```suggestion
       RandomAccessFile* _file = nullptr;
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org