You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by kvr000 <gi...@git.apache.org> on 2017/05/05 03:45:44 UTC
[GitHub] commons-compress pull request #24: COMPRESS-391: Allow alignment on zip cont...
GitHub user kvr000 opened a pull request:
https://github.com/apache/commons-compress/pull/24
COMPRESS-391: Allow alignment on zip content
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kvr000/commons-compress feature/COMPRESS-391-allow-entries-alignment
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-compress/pull/24.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #24
----
commit e42d33b01848cd46c87739bf92c33a6c0f136f32
Author: Zbynek Vyskovsky <kv...@gmail.com>
Date: 2017-05-05T03:44:44Z
COMPRESS-391: Allow alignment on zip content
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-compress issue #24: COMPRESS-391: Allow alignment on zip content
Posted by bodewig <gi...@git.apache.org>.
Github user bodewig commented on the issue:
https://github.com/apache/commons-compress/pull/24
I don't see a chance of making it independent of `ZipArchiveOutputStream`, you are certainly correct.
I was thinking along the lines of `ZipArchiveOutputStream` calculates the length needed for proper alignment, creates an instance of the new extra field passing in the size information necessary and adds it to the `ZipArchiveEntry` - after that the code in `ZipArchiveOutputStream` can be left unchanged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-compress issue #24: COMPRESS-391: Allow alignment on zip content
Posted by kvr000 <gi...@git.apache.org>.
Github user kvr000 commented on the issue:
https://github.com/apache/commons-compress/pull/24
@bodewig : Thanks for suggestions. There are definitely some pros with the approach, especially if it reaches Zip RFC :-)
On the other hand, I don't think it could be made completely independent on ZipArchiveOutputStream as it has to know current stream offset on which to base the alignment.
But I'll check in details...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-compress pull request #24: COMPRESS-391: Allow alignment on zip cont...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/commons-compress/pull/24
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-compress issue #24: COMPRESS-391: Allow alignment on zip content
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/commons-compress/pull/24
[](https://coveralls.io/builds/11383081)
Coverage increased (+0.05%) to 84.279% when pulling **e42d33b01848cd46c87739bf92c33a6c0f136f32 on kvr000:feature/COMPRESS-391-allow-entries-alignment** into **092bcac5be680480860dbddae4217347b8b14fab on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-compress issue #24: COMPRESS-391: Allow alignment on zip content
Posted by bodewig <gi...@git.apache.org>.
Github user bodewig commented on the issue:
https://github.com/apache/commons-compress/pull/24
@kvr000 what do you think about https://github.com/apache/commons-compress/commit/620196621e15a87cdd5e3382504bd8a9829f4698 ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-compress issue #24: COMPRESS-391: Allow alignment on zip content
Posted by bodewig <gi...@git.apache.org>.
Github user bodewig commented on the issue:
https://github.com/apache/commons-compress/pull/24
Many thanks @kvr000
Have you thought about adding a class implementing `ZipExtraField` for padding? You could add that to the entry if you detect padding is necessary and could remove code that now needs to know about the encoding of extra fields from `ZipArchiveOutputStream`. The central directory size should be 0 then.
It would also preserve the padding information when an archive is read which may be useful when re-packing existing entries as you could strip or modify the padding extra field directly.
Finally I wonder whether `setAlignment` should reject values bigger than 64k right away.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-compress issue #24: COMPRESS-391: Allow alignment on zip content
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/commons-compress/pull/24
[](https://coveralls.io/builds/11469394)
Coverage increased (+0.09%) to 84.309% when pulling **77f5ce3714e194704332aa66bca746c9806f2be7 on kvr000:feature/COMPRESS-391-allow-entries-alignment** into **ca7ea939eaa9dad5f00c8a5e269f09681602bc98 on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org