You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2016/06/21 01:05:35 UTC
[Impala-CR](cdh5-trunk) IMPALA-3763: download requirements fixes
Tim Armstrong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/3416
Change subject: IMPALA-3763: download_requirements fixes
......................................................................
IMPALA-3763: download_requirements fixes
* Download to infra/python/deps instead of the current directory.
* Download the correct virtualenv version, to match the version on
cdh5-trunk
* Don't re-download packages repeatedly, instead check the md5sum.
Testing:
Tested manually on the ASF tree, then made sure that
bootstrap_virtualenv completed successfully to make sure we had all
of the requirements downloaded successfully.
Change-Id: I5a3c42236dddfd8a456c82605dc1fdc199a2bc48
---
M infra/python/deps/download_requirements
M infra/python/deps/pip_download.py
2 files changed, 20 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/16/3416/1
--
To view, visit http://gerrit.cloudera.org:8080/3416
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5a3c42236dddfd8a456c82605dc1fdc199a2bc48
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
[Impala-CR](cdh5-trunk) IMPALA-3763: download requirements fixes
Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has submitted this change and it was merged.
Change subject: IMPALA-3763: download_requirements fixes
......................................................................
IMPALA-3763: download_requirements fixes
* Download to infra/python/deps instead of the current directory.
* Download the correct virtualenv version, to match the version on
cdh5-trunk
* Don't re-download packages repeatedly, instead check the md5sum.
Testing:
Tested manually on the ASF tree, then made sure that
bootstrap_virtualenv completed successfully to make sure we had all
of the requirements downloaded successfully.
Change-Id: I5a3c42236dddfd8a456c82605dc1fdc199a2bc48
Reviewed-on: http://gerrit.cloudera.org:8080/3416
Reviewed-by: Jim Apple <jb...@cloudera.com>
Tested-by: Internal Jenkins
---
M infra/python/deps/download_requirements
M infra/python/deps/pip_download.py
2 files changed, 20 insertions(+), 7 deletions(-)
Approvals:
Jim Apple: Looks good to me, approved
Internal Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/3416
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5a3c42236dddfd8a456c82605dc1fdc199a2bc48
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Michael Ho
[Impala-CR](cdh5-trunk) IMPALA-3763: download requirements fixes
Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-3763: download_requirements fixes
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/3416
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a3c42236dddfd8a456c82605dc1fdc199a2bc48
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Michael Ho
Gerrit-HasComments: No
[Impala-CR](cdh5-trunk) IMPALA-3763: download requirements fixes
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: IMPALA-3763: download_requirements fixes
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3416
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a3c42236dddfd8a456c82605dc1fdc199a2bc48
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Michael Ho
Gerrit-HasComments: No