[GitHub] [helix] alirezazamani commented on a change in pull request #1221: (WIP) Drop the task related current states for new session

[GitBox <gi...@apache.org>]

alirezazamani commented on a change in pull request #1221:
URL: https://github.com/apache/helix/pull/1221#discussion_r467270900



##########
File path: helix-core/src/main/java/org/apache/helix/manager/zk/ParticipantManager.java
##########
@@ -350,6 +351,12 @@ private void carryOverPreviousCurrentState() {
                   + lastCurState);
           continue;
         }
+
+        // If the the current state is related to tasks, there is no need to carry it over to new session.
+        if (stateModelDefRef.equals(TaskConstants.STATE_MODEL_NAME)) {
+          continue;
+        }

Review comment:
       When we establishing new session, we will carryover the old current states. If we skip this carry over for the task related current states, then the session will no longer have task related current states. Hence, there is no need to the controller to drop the current state in this case.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org