[GitHub] [solr] aruggero commented on a diff in pull request #1586: SOLR-16759: Introducing logAll parameter in the feature logger

["aruggero (via GitHub)" <gi...@apache.org>]

aruggero commented on code in PR #1586:
URL: https://github.com/apache/solr/pull/1586#discussion_r1192255064


##########
solr/modules/ltr/src/java/org/apache/solr/ltr/response/transform/LTRFeatureLoggerTransformerFactory.java:
##########
@@ -71,8 +71,13 @@ public class LTRFeatureLoggerTransformerFactory extends TransformerFactory {
   // used inside fl to specify the feature store to use for the feature extraction
   private static final String FV_STORE = "store";
 
+  // used inside fl to specify to log (all|model only) features
+  private static final String FV_LOG_ALL = "logAll";
+
   private static String DEFAULT_LOGGING_MODEL_NAME = "logging-model";

Review Comment:
   Final?



##########
solr/modules/ltr/src/java/org/apache/solr/ltr/response/transform/LTRFeatureLoggerTransformerFactory.java:
##########
@@ -71,8 +71,13 @@ public class LTRFeatureLoggerTransformerFactory extends TransformerFactory {
   // used inside fl to specify the feature store to use for the feature extraction
   private static final String FV_STORE = "store";
 
+  // used inside fl to specify to log (all|model only) features
+  private static final String FV_LOG_ALL = "logAll";
+
   private static String DEFAULT_LOGGING_MODEL_NAME = "logging-model";
 
+  private static boolean DEFAULT_NO_RERANKING_LOGGING_ALL = true;

Review Comment:
   Final?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org