You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Thejas Nair <th...@hortonworks.com> on 2014/08/01 00:51:15 UTC
Review Request 24168: HIVE-7579 : error message for 'drop admin role' is not
informative
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24168/
-----------------------------------------------------------
Review request for hive and Jason Dere.
Bugs: HIVE-7579
https://issues.apache.org/jira/browse/HIVE-7579
Repository: hive-git
Description
-------
See jira HIVE-7579
Diffs
-----
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java b74868b
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLAuthorizationUtils.java 6a283ab
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAccessController.java fa77c0c
ql/src/test/queries/clientnegative/authorization_drop_admin_role.q PRE-CREATION
ql/src/test/results/clientnegative/authorization_drop_admin_role.q.out PRE-CREATION
ql/src/test/results/clientnegative/authorization_public_drop.q.out 7759745
ql/src/test/results/clientnegative/authorization_role_cycles1.q.out 032be5b
ql/src/test/results/clientnegative/authorization_role_cycles2.q.out a9d8cfe
Diff: https://reviews.apache.org/r/24168/diff/
Testing
-------
New test included.
Thanks,
Thejas Nair
Re: Review Request 24168: HIVE-7579 : error message for 'drop admin role' is
not informative
Posted by Lars Francke <as...@lars-francke.de>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24168/#review49311
-----------------------------------------------------------
Ship it!
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
<https://reviews.apache.org/r/24168/#comment86269>
Missing space after +
- Lars Francke
On July 31, 2014, 10:51 p.m., Thejas Nair wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24168/
> -----------------------------------------------------------
>
> (Updated July 31, 2014, 10:51 p.m.)
>
>
> Review request for hive and Jason Dere.
>
>
> Bugs: HIVE-7579
> https://issues.apache.org/jira/browse/HIVE-7579
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> See jira HIVE-7579
>
>
> Diffs
> -----
>
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java b74868b
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLAuthorizationUtils.java 6a283ab
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAccessController.java fa77c0c
> ql/src/test/queries/clientnegative/authorization_drop_admin_role.q PRE-CREATION
> ql/src/test/results/clientnegative/authorization_drop_admin_role.q.out PRE-CREATION
> ql/src/test/results/clientnegative/authorization_public_drop.q.out 7759745
> ql/src/test/results/clientnegative/authorization_role_cycles1.q.out 032be5b
> ql/src/test/results/clientnegative/authorization_role_cycles2.q.out a9d8cfe
>
> Diff: https://reviews.apache.org/r/24168/diff/
>
>
> Testing
> -------
>
> New test included.
>
>
> Thanks,
>
> Thejas Nair
>
>
Re: Review Request 24168: HIVE-7579 : error message for 'drop admin role' is
not informative
Posted by Jason Dere <jd...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24168/#review49302
-----------------------------------------------------------
Ship it!
Ship It!
- Jason Dere
On July 31, 2014, 10:51 p.m., Thejas Nair wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24168/
> -----------------------------------------------------------
>
> (Updated July 31, 2014, 10:51 p.m.)
>
>
> Review request for hive and Jason Dere.
>
>
> Bugs: HIVE-7579
> https://issues.apache.org/jira/browse/HIVE-7579
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> See jira HIVE-7579
>
>
> Diffs
> -----
>
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java b74868b
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLAuthorizationUtils.java 6a283ab
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAccessController.java fa77c0c
> ql/src/test/queries/clientnegative/authorization_drop_admin_role.q PRE-CREATION
> ql/src/test/results/clientnegative/authorization_drop_admin_role.q.out PRE-CREATION
> ql/src/test/results/clientnegative/authorization_public_drop.q.out 7759745
> ql/src/test/results/clientnegative/authorization_role_cycles1.q.out 032be5b
> ql/src/test/results/clientnegative/authorization_role_cycles2.q.out a9d8cfe
>
> Diff: https://reviews.apache.org/r/24168/diff/
>
>
> Testing
> -------
>
> New test included.
>
>
> Thanks,
>
> Thejas Nair
>
>