[GitHub] [incubator-druid] sashidhar commented on a change in pull request #8068: Druid SQL EXTRACT time function - adding support for additional Time Units

[GitBox <gi...@apache.org>]

sashidhar commented on a change in pull request #8068: Druid SQL EXTRACT time function - adding support for additional Time Units
URL: https://github.com/apache/incubator-druid/pull/8068#discussion_r303208858
 
 

 ##########
 File path: sql/src/test/java/org/apache/druid/sql/calcite/http/SqlResourceTest.java
 ##########
 @@ -689,6 +689,18 @@ private void checkSqlRequestLog(boolean success)
     }
   }
 
+  @Test
+  public void testExtractMillisecondFromExpr() throws Exception
 
 Review comment:
   Thanks @clintropolis for the pointer. Moved this test to CalciteQueryTest. Added testFilterOnTimeExtractWithMilliseconds() in CalciteQueryTest. If the code changes look fine I'll go ahead and handle other time units. Introduced new data source DATASOURCE4 in tests so as to test other time units as well.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org