You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@guacamole.apache.org by mike-jumper <gi...@git.apache.org> on 2016/06/03 18:33:38 UTC

[GitHub] incubator-guacamole-server pull request #13: GUACAMOLE-44: Avoid unnecessary...

GitHub user mike-jumper opened a pull request:

    https://github.com/apache/incubator-guacamole-server/pull/13

    GUACAMOLE-44: Avoid unnecessary allocation of temporary string for guac_rdp_ptr_to_string().

    The current code leaks the storage for the stringified pointer allocated by `guac_rdp_ptr_to_string()`, but it's really not necessary allocate the string at all. Better that `guac_rdp_ptr_to_string()` be provided a sufficiently-large buffer.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mike-jumper/incubator-guacamole-server fix-leak

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-guacamole-server/pull/13.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #13
    
----
commit c881efae0c762f693fecf9a85499cb46785971e1
Author: Michael Jumper <mj...@apache.org>
Date:   2016-06-03T18:30:05Z

    GUACAMOLE-44: Avoid unnecessary allocation of temporary string for guac_rdp_ptr_to_string().

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-guacamole-server pull request #13: GUACAMOLE-25: Avoid unnecessary...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-guacamole-server/pull/13


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---