[GitHub] [hadoop] nandakumar131 commented on a change in pull request #1211: HDDS-1888. Add containers to node2container map in SCM as soon as a container is created.

[GitBox <gi...@apache.org>]

nandakumar131 commented on a change in pull request #1211: HDDS-1888. Add containers to node2container map in SCM as soon as a container is created.
URL: https://github.com/apache/hadoop/pull/1211#discussion_r311564536
 
 

 ##########
 File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/states/NodeStateMap.java
 ##########
 @@ -224,6 +224,23 @@ public NodeState getNodeState(UUID uuid) throws NodeNotFoundException {
     }
   }
 
+  /**
+   * Adds the given container to the specified datanode.
+   *
+   * @param uuid - datanode uuid
+   * @param containerId - containerID
+   * @throws NodeNotFoundException - if datanode is not known. For new datanode
+   *                        use addDatanodeInContainerMap call.
+   */
+  public void addContainer(final UUID uuid,
+                           final ContainerID containerId)
+      throws NodeNotFoundException {
+    if (!nodeToContainer.containsKey(uuid)) {
+      throw new NodeNotFoundException("Node UUID: " + uuid);
+    }
+    nodeToContainer.get(uuid).add(containerId);
 
 Review comment:
   For now we don't ever remove a datanode from NodeManager once it is registered. We should not remove dn once it is dead, we will not be able to show list of dead nodes to the user.
   Maybe as part of decommissioning once the decommission is successful we can remove the dn.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org