[GitHub] [iceberg] ajantha-bhat commented on a diff in pull request #5185: Spark: Parse sort orders with zorder expressions

[GitBox <gi...@apache.org>]

ajantha-bhat commented on code in PR #5185:
URL: https://github.com/apache/iceberg/pull/5185#discussion_r912621854


##########
api/src/main/java/org/apache/iceberg/expressions/Zorder.java:
##########
@@ -17,24 +17,19 @@
  * under the License.
  */
 
-package org.apache.spark.sql.catalyst.plans.logical
+package org.apache.iceberg.expressions;
 
-import org.apache.iceberg.NullOrder
-import org.apache.iceberg.Schema
-import org.apache.iceberg.SortDirection
-import org.apache.iceberg.SortOrder
-import org.apache.iceberg.expressions.Term
+import java.util.Arrays;
+import java.util.List;
 
-class SortOrderParserUtil {
+public class Zorder implements Term {

Review Comment:
   should this implement `UnboundTerm`?
   
   Because `SortOrder` only accepts `UnboundTerm`. https://github.com/apache/iceberg/blob/master/api/src/main/java/org/apache/iceberg/SortOrder.java#L258
   
   Also, Now `sortOrder` needs some extra array or list that says which of the fields are Zordered in the sortOrder?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org