You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/12/14 18:44:48 UTC
[GitHub] [camel-k] astefanutti opened a new pull request #2833: fix(e2e): Avoid nested Gomega nested fields matcher
astefanutti opened a new pull request #2833:
URL: https://github.com/apache/camel-k/pull/2833
**Release Note**
```release-note
fix(e2e): Avoid nested Gomega nested fields matcher
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on pull request #2833: fix(e2e): Avoid nested Gomega fields matcher
Posted by GitBox <gi...@apache.org>.
squakez commented on pull request #2833:
URL: https://github.com/apache/camel-k/pull/2833#issuecomment-994702842
Unfortunately, this still fails: https://github.com/apache/camel-k/runs/4532928843?check_suite_focus=true
```
=== RUN TestMetrics/reconciliation_duration_metric
operator_metrics_test.go:272:
Expected
<uint>: 12
to be ==
<uint64>: 11
```
It's the same pattern I've observed lately. Sometimes it fail with the metrics having +1 sample counted. I've collected traces to see if the counter is called more than expected, and it did not happen. Either the sum of the metrics is not calculated correctly, or there is some hidden call to the metrics reconcile which create that additional sample. What I managed to see is that most of the time it happens when one of the reconciliation takes long (more than 30 seconds), altough, also in that case I cannot log any further execution that the ones expected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on pull request #2833: fix(e2e): Avoid nested Gomega fields matcher
Posted by GitBox <gi...@apache.org>.
squakez commented on pull request #2833:
URL: https://github.com/apache/camel-k/pull/2833#issuecomment-994841633
> That's an additional issue, that's hopefully fixed with #2836.
Those requeued may be the reason, altough I never managed to capture a trace of them during my experiments. Let's see how it goes. :crossed_fingers:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti commented on pull request #2833: fix(e2e): Avoid nested Gomega fields matcher
Posted by GitBox <gi...@apache.org>.
astefanutti commented on pull request #2833:
URL: https://github.com/apache/camel-k/pull/2833#issuecomment-994747108
That's an additional issue, that's hopefully fixed with #2836.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti commented on pull request #2833: fix(e2e): Avoid nested Gomega fields matcher
Posted by GitBox <gi...@apache.org>.
astefanutti commented on pull request #2833:
URL: https://github.com/apache/camel-k/pull/2833#issuecomment-994669960
> Hope this has better luck than the experiments I'm running. However, I see that the comparison done is the same.
_"Once you eliminate the impossible, whatever remains, no matter how improbable, must be the truth."_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti merged pull request #2833: fix(e2e): Avoid nested Gomega fields matcher
Posted by GitBox <gi...@apache.org>.
astefanutti merged pull request #2833:
URL: https://github.com/apache/camel-k/pull/2833
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org