You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openwebbeans.apache.org by Gurkan Erdogdu <gu...@yahoo.com> on 2010/12/14 21:50:46 UTC

Yan:: svn commit: r1049215 - in /openwebbeans/trunk/webbeans-impl/src: main/java/org/apache/webbeans/event/NotificationManager.java test/java/org/apache/webbeans/newtests/portable/events/extensions/AddObserverMethodExtension.java

As pete mail, javadoc is correct therefore i reverted change before. If javadoc is correct those tck tests must be excluded. our code is correct because it is aligned with published javadoc

Sal, 14 Ara 2010 20:51 EET tarihinde djencks@apache.org şöyle yazdı:

>Author: djencks
>Date: Tue Dec 14 18:51:54 2010
>New Revision: 1049215
>
>URL: http://svn.apache.org/viewvc?rev=1049215&view=rev
>Log:
>OWB-490, CDITCK-174 reapply rev 1034955 to comply with cdi tck 1.0.2.SP1
>
>Modified:
>    openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/event/NotificationManager.java
>    openwebbeans/trunk/webbeans-impl/src/test/java/org/apache/webbeans/newtests/portable/events/extensions/AddObserverMethodExtension.java
>
>Modified: openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/event/NotificationManager.java
>URL: http://svn.apache.org/viewvc/openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/event/NotificationManager.java?rev=1049215&r1=1049214&r2=1049215&view=diff
>==============================================================================
>--- openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/event/NotificationManager.java (original)
>+++ openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/event/NotificationManager.java Tue Dec 14 18:51:54 2010
>@@ -354,13 +354,7 @@ public final class NotificationManager
>         {
>             Type beanClassArg = actualArgs[0];
>             Type returnClassArg = actualArgs[1];
>-            
>-            if(isObserverMethod)
>-            {
>-                beanClassArg = actualArgs[1];
>-                returnClassArg = actualArgs[0];
>-            }
>-            
>+                        
>             if(checkEventTypeParameterForExtensions(beanClass, beanClassArg) && 
>                     checkEventTypeParameterForExtensions(producerOrObserverReturnClass, returnClassArg))
>             {
>
>Modified: openwebbeans/trunk/webbeans-impl/src/test/java/org/apache/webbeans/newtests/portable/events/extensions/AddObserverMethodExtension.java
>URL: http://svn.apache.org/viewvc/openwebbeans/trunk/webbeans-impl/src/test/java/org/apache/webbeans/newtests/portable/events/extensions/AddObserverMethodExtension.java?rev=1049215&r1=1049214&r2=1049215&view=diff
>==============================================================================
>--- openwebbeans/trunk/webbeans-impl/src/test/java/org/apache/webbeans/newtests/portable/events/extensions/AddObserverMethodExtension.java (original)
>+++ openwebbeans/trunk/webbeans-impl/src/test/java/org/apache/webbeans/newtests/portable/events/extensions/AddObserverMethodExtension.java Tue Dec 14 18:51:54 2010
>@@ -40,9 +40,9 @@ public class AddObserverMethodExtension 
>     
>     public static class MyBeanExtension implements Extension
>     {
>-        public static ObserverMethod<MyEvent> observerMethod;
>+        public static ObserverMethod<AddObserverMethodExtension> observerMethod;
>         
>-        public void observer(@Observes ProcessObserverMethod<MyEvent, AddObserverMethodExtension> event)
>+        public void observer(@Observes ProcessObserverMethod<AddObserverMethodExtension, MyEvent> event)
>         {
>             observerMethod = event.getObserverMethod();
>             
>
>




Re: Yan:: svn commit: r1049215 - in /openwebbeans/trunk/webbeans-impl/src: main/java/org/apache/webbeans/event/NotificationManager.java test/java/org/apache/webbeans/newtests/portable/events/extensions/AddObserverMethodExtension.java

Posted by Gurkan Erdogdu <gu...@yahoo.com>.
Hi 

I have opened a JIRA issue, https://issues.jboss.org/browse/CDITCK-199

>>>Is it to fail the most recent tck and ignore the problem? 
No. Passing TCK is always higher priority...

Thanks;

--Gurkan



----- Original Message ----
From: David Jencks <da...@yahoo.com>
To: dev@openwebbeans.apache.org
Sent: Wed, December 15, 2010 12:00:31 AM
Subject: Re: Yan:: svn commit: r1049215 - in 
/openwebbeans/trunk/webbeans-impl/src: 
main/java/org/apache/webbeans/event/NotificationManager.java 
test/java/org/apache/webbeans/newtests/portable/events/extensions/AddObserverMethodExtension.java


IMO the changes committed to the tck for CDITCK-174 require the changes I 
committed to OWB in order to pass.  The changes in the tck for CDITCk-174 are 
still present in the 1.0.2.SP1 tck.  If you think these contradict the javadoc 
can you file a new CDITCK jira or reopen CDITCK-174 or take some other 
appropriate action with Pete or other CDI EG representative?  I don't understand 
what course of action you want to follow.  Is it to fail the most recent tck and 
ignore the problem?

thanks
david jencks

On Dec 14, 2010, at 1:14 PM, Mark Struberg wrote:

> David, as clarified by the JSP EC, API Javadocs are _always_ correct if there 
>is any question or discrepance with the written spec.
> 
> I have not looked at the Javadoc, but please also check the corresponding 
>CDI-TCK-174
> 
> https://issues.jboss.org/browse/CDITCK-174
> 
> 
> LieGrue,
> strub
> 
> --- On Tue, 12/14/10, David Jencks <da...@yahoo.com> wrote:
> 
>> From: David Jencks <da...@yahoo.com>
>> Subject: Re: Yan:: svn commit: r1049215 - in 
>>/openwebbeans/trunk/webbeans-impl/src: 
>>main/java/org/apache/webbeans/event/NotificationManager.java 
>>test/java/org/apache/webbeans/newtests/portable/events/extensions/AddObserverMethodExtension.java
>>
>> To: dev@openwebbeans.apache.org
>> Date: Tuesday, December 14, 2010, 9:02 PM
>> Since there's a new released tck that
>> doesn't change or exclude the tests in question, I tend to
>> think that current opinion in the cdi EG is that the javadoc
>> is wrong.  Can you take this up with pete to find out
>> what's going on?  Meanwhile I would think there would
>> be some interest in passing the tck.
>> 
>> thanks
>> david jencks
>> 
>> On Dec 14, 2010, at 12:50 PM, Gurkan Erdogdu wrote:
>> 
>>> As pete mail, javadoc is correct therefore i reverted
>> change before. If javadoc is correct those tck tests must be
>> excluded. our code is correct because it is aligned with
>> published javadoc
>>> 
>>> Sal, 14 Ara 2010 20:51 EET tarihinde djencks@apache.org
>> şöyle yazdı:
>>> 
>>>> Author: djencks
>>>> Date: Tue Dec 14 18:51:54 2010
>>>> New Revision: 1049215
>>>> 
>>>> URL: http://svn.apache.org/viewvc?rev=1049215&view=rev
>>>> Log:
>>>> OWB-490, CDITCK-174 reapply rev 1034955 to comply
>> with cdi tck 1.0.2.SP1
>>>> 
>>>> Modified:
>>>>    
>>>>openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/event/NotificationManager.java
>>>>
>>>>    
>>>>openwebbeans/trunk/webbeans-impl/src/test/java/org/apache/webbeans/newtests/portable/events/extensions/AddObserverMethodExtension.java
>>>>
>>>> 
>>>> Modified:
>>openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/event/NotificationManager.java
>>a
>>>> URL: 
>>>>http://svn.apache.org/viewvc/openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/event/NotificationManager.java?rev=1049215&r1=1049214&r2=1049215&view=diff
>>>>
>>>> 
>> 
==============================================================================
>>>> ---
>>openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/event/NotificationManager.java
>>a
>> (original)
>>>> +++
>>openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/event/NotificationManager.java
>>a
>> Tue Dec 14 18:51:54 2010
>>>> @@ -354,13 +354,7 @@ public final class
>> NotificationManager
>>>>         {
>>>>             Type
>> beanClassArg = actualArgs[0];
>>>>             Type
>> returnClassArg = actualArgs[1];
>>>> -            
>>>> -          
>> if(isObserverMethod)
>>>> -            {
>>>> -            
>>   beanClassArg = actualArgs[1];
>>>> -            
>>   returnClassArg = actualArgs[0];
>>>> -            }
>>>> -            
>>>> +            
>>          
>>>>            
>> if(checkEventTypeParameterForExtensions(beanClass,
>> beanClassArg) && 
>>>>              
>>      
>> checkEventTypeParameterForExtensions(producerOrObserverReturnClass,
>> returnClassArg))
>>>>             {
>>>> 
>>>> Modified:
>>openwebbeans/trunk/webbeans-impl/src/test/java/org/apache/webbeans/newtests/portable/events/extensions/AddObserverMethodExtension.java
>>a
>>>> URL: 
>>>>http://svn.apache.org/viewvc/openwebbeans/trunk/webbeans-impl/src/test/java/org/apache/webbeans/newtests/portable/events/extensions/AddObserverMethodExtension.java?rev=1049215&r1=1049214&r2=1049215&view=diff
>>>>
>>>> 
>> 
==============================================================================
>>>> ---
>>openwebbeans/trunk/webbeans-impl/src/test/java/org/apache/webbeans/newtests/portable/events/extensions/AddObserverMethodExtension.java
>>a
>> (original)
>>>> +++
>>openwebbeans/trunk/webbeans-impl/src/test/java/org/apache/webbeans/newtests/portable/events/extensions/AddObserverMethodExtension.java
>>a
>> Tue Dec 14 18:51:54 2010
>>>> @@ -40,9 +40,9 @@ public class
>> AddObserverMethodExtension 
>>>> 
>>>>     public static class MyBeanExtension
>> implements Extension
>>>>     {
>>>> -        public static
>> ObserverMethod<MyEvent> observerMethod;
>>>> +        public static
>> ObserverMethod<AddObserverMethodExtension>
>> observerMethod;
>>>> 
>>>> -        public void
>> observer(@Observes ProcessObserverMethod<MyEvent,
>> AddObserverMethodExtension> event)
>>>> +        public void
>> observer(@Observes
>> ProcessObserverMethod<AddObserverMethodExtension,
>> MyEvent> event)
>>>>         {
>>>>            
>> observerMethod = event.getObserverMethod();
>>>> 
>>>> 
>>>> 
>>> 
>>> 
>>> 
>> 
>> 
> 
> 
> 



Re: Yan:: svn commit: r1049215 - in /openwebbeans/trunk/webbeans-impl/src: main/java/org/apache/webbeans/event/NotificationManager.java test/java/org/apache/webbeans/newtests/portable/events/extensions/AddObserverMethodExtension.java

Posted by David Jencks <da...@yahoo.com>.
IMO the changes committed to the tck for CDITCK-174 require the changes I committed to OWB in order to pass.  The changes in the tck for CDITCk-174 are still present in the 1.0.2.SP1 tck.  If you think these contradict the javadoc can you file a new CDITCK jira or reopen CDITCK-174 or take some other appropriate action with Pete or other CDI EG representative?  I don't understand what course of action you want to follow.  Is it to fail the most recent tck and ignore the problem?

thanks
david jencks

On Dec 14, 2010, at 1:14 PM, Mark Struberg wrote:

> David, as clarified by the JSP EC, API Javadocs are _always_ correct if there is any question or discrepance with the written spec.
> 
> I have not looked at the Javadoc, but please also check the corresponding CDI-TCK-174
> 
> https://issues.jboss.org/browse/CDITCK-174
> 
> 
> LieGrue,
> strub
> 
> --- On Tue, 12/14/10, David Jencks <da...@yahoo.com> wrote:
> 
>> From: David Jencks <da...@yahoo.com>
>> Subject: Re: Yan:: svn commit: r1049215 - in /openwebbeans/trunk/webbeans-impl/src: main/java/org/apache/webbeans/event/NotificationManager.java test/java/org/apache/webbeans/newtests/portable/events/extensions/AddObserverMethodExtension.java
>> To: dev@openwebbeans.apache.org
>> Date: Tuesday, December 14, 2010, 9:02 PM
>> Since there's a new released tck that
>> doesn't change or exclude the tests in question, I tend to
>> think that current opinion in the cdi EG is that the javadoc
>> is wrong.  Can you take this up with pete to find out
>> what's going on?  Meanwhile I would think there would
>> be some interest in passing the tck.
>> 
>> thanks
>> david jencks
>> 
>> On Dec 14, 2010, at 12:50 PM, Gurkan Erdogdu wrote:
>> 
>>> As pete mail, javadoc is correct therefore i reverted
>> change before. If javadoc is correct those tck tests must be
>> excluded. our code is correct because it is aligned with
>> published javadoc
>>> 
>>> Sal, 14 Ara 2010 20:51 EET tarihinde djencks@apache.org
>> şöyle yazdı:
>>> 
>>>> Author: djencks
>>>> Date: Tue Dec 14 18:51:54 2010
>>>> New Revision: 1049215
>>>> 
>>>> URL: http://svn.apache.org/viewvc?rev=1049215&view=rev
>>>> Log:
>>>> OWB-490, CDITCK-174 reapply rev 1034955 to comply
>> with cdi tck 1.0.2.SP1
>>>> 
>>>> Modified:
>>>>    openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/event/NotificationManager.java
>>>>    openwebbeans/trunk/webbeans-impl/src/test/java/org/apache/webbeans/newtests/portable/events/extensions/AddObserverMethodExtension.java
>>>> 
>>>> Modified:
>> openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/event/NotificationManager.java
>>>> URL: http://svn.apache.org/viewvc/openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/event/NotificationManager.java?rev=1049215&r1=1049214&r2=1049215&view=diff
>>>> 
>> ==============================================================================
>>>> ---
>> openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/event/NotificationManager.java
>> (original)
>>>> +++
>> openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/event/NotificationManager.java
>> Tue Dec 14 18:51:54 2010
>>>> @@ -354,13 +354,7 @@ public final class
>> NotificationManager
>>>>         {
>>>>             Type
>> beanClassArg = actualArgs[0];
>>>>             Type
>> returnClassArg = actualArgs[1];
>>>> -            
>>>> -           
>> if(isObserverMethod)
>>>> -            {
>>>> -             
>>   beanClassArg = actualArgs[1];
>>>> -             
>>   returnClassArg = actualArgs[0];
>>>> -            }
>>>> -            
>>>> +             
>>           
>>>>            
>> if(checkEventTypeParameterForExtensions(beanClass,
>> beanClassArg) && 
>>>>              
>>      
>> checkEventTypeParameterForExtensions(producerOrObserverReturnClass,
>> returnClassArg))
>>>>             {
>>>> 
>>>> Modified:
>> openwebbeans/trunk/webbeans-impl/src/test/java/org/apache/webbeans/newtests/portable/events/extensions/AddObserverMethodExtension.java
>>>> URL: http://svn.apache.org/viewvc/openwebbeans/trunk/webbeans-impl/src/test/java/org/apache/webbeans/newtests/portable/events/extensions/AddObserverMethodExtension.java?rev=1049215&r1=1049214&r2=1049215&view=diff
>>>> 
>> ==============================================================================
>>>> ---
>> openwebbeans/trunk/webbeans-impl/src/test/java/org/apache/webbeans/newtests/portable/events/extensions/AddObserverMethodExtension.java
>> (original)
>>>> +++
>> openwebbeans/trunk/webbeans-impl/src/test/java/org/apache/webbeans/newtests/portable/events/extensions/AddObserverMethodExtension.java
>> Tue Dec 14 18:51:54 2010
>>>> @@ -40,9 +40,9 @@ public class
>> AddObserverMethodExtension 
>>>> 
>>>>     public static class MyBeanExtension
>> implements Extension
>>>>     {
>>>> -        public static
>> ObserverMethod<MyEvent> observerMethod;
>>>> +        public static
>> ObserverMethod<AddObserverMethodExtension>
>> observerMethod;
>>>> 
>>>> -        public void
>> observer(@Observes ProcessObserverMethod<MyEvent,
>> AddObserverMethodExtension> event)
>>>> +        public void
>> observer(@Observes
>> ProcessObserverMethod<AddObserverMethodExtension,
>> MyEvent> event)
>>>>         {
>>>>            
>> observerMethod = event.getObserverMethod();
>>>> 
>>>> 
>>>> 
>>> 
>>> 
>>> 
>> 
>> 
> 
> 
> 


Re: Yan:: svn commit: r1049215 - in /openwebbeans/trunk/webbeans-impl/src: main/java/org/apache/webbeans/event/NotificationManager.java test/java/org/apache/webbeans/newtests/portable/events/extensions/AddObserverMethodExtension.java

Posted by Mark Struberg <st...@yahoo.de>.
David, as clarified by the JSP EC, API Javadocs are _always_ correct if there is any question or discrepance with the written spec.

I have not looked at the Javadoc, but please also check the corresponding CDI-TCK-174

https://issues.jboss.org/browse/CDITCK-174


LieGrue,
strub

--- On Tue, 12/14/10, David Jencks <da...@yahoo.com> wrote:

> From: David Jencks <da...@yahoo.com>
> Subject: Re: Yan:: svn commit: r1049215 - in /openwebbeans/trunk/webbeans-impl/src: main/java/org/apache/webbeans/event/NotificationManager.java test/java/org/apache/webbeans/newtests/portable/events/extensions/AddObserverMethodExtension.java
> To: dev@openwebbeans.apache.org
> Date: Tuesday, December 14, 2010, 9:02 PM
> Since there's a new released tck that
> doesn't change or exclude the tests in question, I tend to
> think that current opinion in the cdi EG is that the javadoc
> is wrong.  Can you take this up with pete to find out
> what's going on?  Meanwhile I would think there would
> be some interest in passing the tck.
> 
> thanks
> david jencks
> 
> On Dec 14, 2010, at 12:50 PM, Gurkan Erdogdu wrote:
> 
> > As pete mail, javadoc is correct therefore i reverted
> change before. If javadoc is correct those tck tests must be
> excluded. our code is correct because it is aligned with
> published javadoc
> > 
> > Sal, 14 Ara 2010 20:51 EET tarihinde djencks@apache.org
> şöyle yazdı:
> > 
> >> Author: djencks
> >> Date: Tue Dec 14 18:51:54 2010
> >> New Revision: 1049215
> >> 
> >> URL: http://svn.apache.org/viewvc?rev=1049215&view=rev
> >> Log:
> >> OWB-490, CDITCK-174 reapply rev 1034955 to comply
> with cdi tck 1.0.2.SP1
> >> 
> >> Modified:
> >>   openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/event/NotificationManager.java
> >>   openwebbeans/trunk/webbeans-impl/src/test/java/org/apache/webbeans/newtests/portable/events/extensions/AddObserverMethodExtension.java
> >> 
> >> Modified:
> openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/event/NotificationManager.java
> >> URL: http://svn.apache.org/viewvc/openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/event/NotificationManager.java?rev=1049215&r1=1049214&r2=1049215&view=diff
> >>
> ==============================================================================
> >> ---
> openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/event/NotificationManager.java
> (original)
> >> +++
> openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/event/NotificationManager.java
> Tue Dec 14 18:51:54 2010
> >> @@ -354,13 +354,7 @@ public final class
> NotificationManager
> >>        {
> >>            Type
> beanClassArg = actualArgs[0];
> >>            Type
> returnClassArg = actualArgs[1];
> >> -            
> >> -           
> if(isObserverMethod)
> >> -            {
> >> -             
>   beanClassArg = actualArgs[1];
> >> -             
>   returnClassArg = actualArgs[0];
> >> -            }
> >> -            
> >> +             
>           
> >>           
> if(checkEventTypeParameterForExtensions(beanClass,
> beanClassArg) && 
> >>             
>      
> checkEventTypeParameterForExtensions(producerOrObserverReturnClass,
> returnClassArg))
> >>            {
> >> 
> >> Modified:
> openwebbeans/trunk/webbeans-impl/src/test/java/org/apache/webbeans/newtests/portable/events/extensions/AddObserverMethodExtension.java
> >> URL: http://svn.apache.org/viewvc/openwebbeans/trunk/webbeans-impl/src/test/java/org/apache/webbeans/newtests/portable/events/extensions/AddObserverMethodExtension.java?rev=1049215&r1=1049214&r2=1049215&view=diff
> >>
> ==============================================================================
> >> ---
> openwebbeans/trunk/webbeans-impl/src/test/java/org/apache/webbeans/newtests/portable/events/extensions/AddObserverMethodExtension.java
> (original)
> >> +++
> openwebbeans/trunk/webbeans-impl/src/test/java/org/apache/webbeans/newtests/portable/events/extensions/AddObserverMethodExtension.java
> Tue Dec 14 18:51:54 2010
> >> @@ -40,9 +40,9 @@ public class
> AddObserverMethodExtension 
> >> 
> >>    public static class MyBeanExtension
> implements Extension
> >>    {
> >> -        public static
> ObserverMethod<MyEvent> observerMethod;
> >> +        public static
> ObserverMethod<AddObserverMethodExtension>
> observerMethod;
> >> 
> >> -        public void
> observer(@Observes ProcessObserverMethod<MyEvent,
> AddObserverMethodExtension> event)
> >> +        public void
> observer(@Observes
> ProcessObserverMethod<AddObserverMethodExtension,
> MyEvent> event)
> >>        {
> >>           
> observerMethod = event.getObserverMethod();
> >> 
> >> 
> >> 
> > 
> > 
> > 
> 
> 


      

Re: Yan:: svn commit: r1049215 - in /openwebbeans/trunk/webbeans-impl/src: main/java/org/apache/webbeans/event/NotificationManager.java test/java/org/apache/webbeans/newtests/portable/events/extensions/AddObserverMethodExtension.java

Posted by David Jencks <da...@yahoo.com>.
Since there's a new released tck that doesn't change or exclude the tests in question, I tend to think that current opinion in the cdi EG is that the javadoc is wrong.  Can you take this up with pete to find out what's going on?  Meanwhile I would think there would be some interest in passing the tck.

thanks
david jencks

On Dec 14, 2010, at 12:50 PM, Gurkan Erdogdu wrote:

> As pete mail, javadoc is correct therefore i reverted change before. If javadoc is correct those tck tests must be excluded. our code is correct because it is aligned with published javadoc
> 
> Sal, 14 Ara 2010 20:51 EET tarihinde djencks@apache.org şöyle yazdı:
> 
>> Author: djencks
>> Date: Tue Dec 14 18:51:54 2010
>> New Revision: 1049215
>> 
>> URL: http://svn.apache.org/viewvc?rev=1049215&view=rev
>> Log:
>> OWB-490, CDITCK-174 reapply rev 1034955 to comply with cdi tck 1.0.2.SP1
>> 
>> Modified:
>>   openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/event/NotificationManager.java
>>   openwebbeans/trunk/webbeans-impl/src/test/java/org/apache/webbeans/newtests/portable/events/extensions/AddObserverMethodExtension.java
>> 
>> Modified: openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/event/NotificationManager.java
>> URL: http://svn.apache.org/viewvc/openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/event/NotificationManager.java?rev=1049215&r1=1049214&r2=1049215&view=diff
>> ==============================================================================
>> --- openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/event/NotificationManager.java (original)
>> +++ openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/event/NotificationManager.java Tue Dec 14 18:51:54 2010
>> @@ -354,13 +354,7 @@ public final class NotificationManager
>>        {
>>            Type beanClassArg = actualArgs[0];
>>            Type returnClassArg = actualArgs[1];
>> -            
>> -            if(isObserverMethod)
>> -            {
>> -                beanClassArg = actualArgs[1];
>> -                returnClassArg = actualArgs[0];
>> -            }
>> -            
>> +                        
>>            if(checkEventTypeParameterForExtensions(beanClass, beanClassArg) && 
>>                    checkEventTypeParameterForExtensions(producerOrObserverReturnClass, returnClassArg))
>>            {
>> 
>> Modified: openwebbeans/trunk/webbeans-impl/src/test/java/org/apache/webbeans/newtests/portable/events/extensions/AddObserverMethodExtension.java
>> URL: http://svn.apache.org/viewvc/openwebbeans/trunk/webbeans-impl/src/test/java/org/apache/webbeans/newtests/portable/events/extensions/AddObserverMethodExtension.java?rev=1049215&r1=1049214&r2=1049215&view=diff
>> ==============================================================================
>> --- openwebbeans/trunk/webbeans-impl/src/test/java/org/apache/webbeans/newtests/portable/events/extensions/AddObserverMethodExtension.java (original)
>> +++ openwebbeans/trunk/webbeans-impl/src/test/java/org/apache/webbeans/newtests/portable/events/extensions/AddObserverMethodExtension.java Tue Dec 14 18:51:54 2010
>> @@ -40,9 +40,9 @@ public class AddObserverMethodExtension 
>> 
>>    public static class MyBeanExtension implements Extension
>>    {
>> -        public static ObserverMethod<MyEvent> observerMethod;
>> +        public static ObserverMethod<AddObserverMethodExtension> observerMethod;
>> 
>> -        public void observer(@Observes ProcessObserverMethod<MyEvent, AddObserverMethodExtension> event)
>> +        public void observer(@Observes ProcessObserverMethod<AddObserverMethodExtension, MyEvent> event)
>>        {
>>            observerMethod = event.getObserverMethod();
>> 
>> 
>> 
> 
> 
>