You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/04/17 21:06:20 UTC
[GitHub] [spark] mengxr commented on a change in pull request #24387:
[SPARK-27473][SQL][WIP] Support filter push down for status fields in
binary file data source
mengxr commented on a change in pull request #24387: [SPARK-27473][SQL][WIP] Support filter push down for status fields in binary file data source
URL: https://github.com/apache/spark/pull/24387#discussion_r276433773
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/binaryfile/BinaryFileFormat.scala
##########
@@ -160,8 +235,10 @@ object BinaryFileFormat {
* - length (LongType): The length of the file in bytes.
*/
val schema = StructType(
- StructField("content", BinaryType, true) ::
- StructField("status", fileStatusSchema, false) :: Nil)
+ StructField("path", StringType, false) ::
+ StructField("modificationTime", TimestampType, false) ::
Review comment:
Please update the API doc too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org