You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@isis.apache.org by ah...@apache.org on 2020/06/09 07:35:17 UTC

[isis] branch master updated: ISIS-2372: Confirm Dialog: render below instead of right of button

This is an automated email from the ASF dual-hosted git repository.

ahuber pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/isis.git


The following commit(s) were added to refs/heads/master by this push:
     new 9335160  ISIS-2372: Confirm Dialog: render below instead of right of button
9335160 is described below

commit 9335160b21e0c96bea4a44cabd71d9132341b399
Author: Andi Huber <ah...@apache.org>
AuthorDate: Tue Jun 9 09:35:02 2020 +0200

    ISIS-2372: Confirm Dialog: render below instead of right of button
---
 .../ui/components/actionmenu/entityactions/AdditionalLinksPanel.java    | 2 +-
 .../isis/viewer/wicket/ui/components/actions/ActionParametersForm.java  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/actionmenu/entityactions/AdditionalLinksPanel.java b/viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/actionmenu/entityactions/AdditionalLinksPanel.java
index 7e1c730..15887b1 100644
--- a/viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/actionmenu/entityactions/AdditionalLinksPanel.java
+++ b/viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/actionmenu/entityactions/AdditionalLinksPanel.java
@@ -143,7 +143,7 @@ public class AdditionalLinksPanel extends PanelAbstract<ListOfLinksModel> {
                                 ? _Strings.isNotEmpty(((ActionLink)link).getReasonDisabledIfAny()) 
                                 : false;
                         if (!hasDisabledReason) {
-                            val confirmUiModel = ConfirmUiModel.ofAreYouSure(getTranslationService(), Placement.RIGHT);
+                            val confirmUiModel = ConfirmUiModel.ofAreYouSure(getTranslationService(), Placement.BOTTOM);
                             Decorators.getConfirm().decorate(link, confirmUiModel);
                         }
                     }
diff --git a/viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/actions/ActionParametersForm.java b/viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/actions/ActionParametersForm.java
index d3a54af..0775c0e 100644
--- a/viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/actions/ActionParametersForm.java
+++ b/viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/actions/ActionParametersForm.java
@@ -143,7 +143,7 @@ class ActionParametersForm extends PromptFormAbstract<ActionModel> {
         val action = actionModel.getMetaModel();
         
         if (action.getSemantics().isAreYouSure()) {
-            val confirmUiModel = ConfirmUiModel.ofAreYouSure(getTranslationService(), Placement.RIGHT);
+            val confirmUiModel = ConfirmUiModel.ofAreYouSure(getTranslationService(), Placement.BOTTOM);
             Decorators.getConfirm().decorate(button, confirmUiModel);
         }
     }