You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/01/19 11:05:11 UTC

[GitHub] [ozone] kuenishi opened a new pull request #3001: HDDS-6206. Application errors must not flood system log

kuenishi opened a new pull request #3001:
URL: https://github.com/apache/ozone/pull/3001


   ## What changes were proposed in this pull request?
   
   Frequent errors such as NoSuchBucket or NoSuchKey must not write down error logs. They should be in audit logs in principles. Otherwise, we may miss important errors like NullPointerException that does not appear in healthy system. To make sure that we can keep eyes on system health than access by applications, errors that stem from applications must not be printed in normal log files.
   
   ## What is the link to the Apache JIRA
   
   HDDS-6206
   
   ## How was this patch tested?
   
   Unit tests by CI
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] adoroszlai commented on a change in pull request #3001: HDDS-6206. Application errors must not flood system log

Posted by GitBox <gi...@apache.org>.
adoroszlai commented on a change in pull request #3001:
URL: https://github.com/apache/ozone/pull/3001#discussion_r797327427



##########
File path: hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/exception/S3ErrorTable.java
##########
@@ -130,7 +130,11 @@ public static OS3Exception newError(OS3Exception e, String resource) {
     OS3Exception err =  new OS3Exception(e.getCode(), e.getErrorMessage(),
         e.getHttpCode());
     err.setResource(resource);
-    LOG.error(err.toXml(), e);
+    if (e.getHttpCode() == HTTP_INTERNAL_ERROR) {
+      LOG.error("Internal Error: {}", err.toXml(), e);
+    } else {

Review comment:
       ```suggestion
       } else if (LOG.isDebugEnabled()) {
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] kuenishi commented on pull request #3001: HDDS-6206. Application errors must not flood system log

Posted by GitBox <gi...@apache.org>.
kuenishi commented on pull request #3001:
URL: https://github.com/apache/ozone/pull/3001#issuecomment-1028540353


   @adoroszlai Thanks for review. I committed your proposal.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] adoroszlai merged pull request #3001: HDDS-6206. Application errors must not flood system log

Posted by GitBox <gi...@apache.org>.
adoroszlai merged pull request #3001:
URL: https://github.com/apache/ozone/pull/3001


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] adoroszlai commented on pull request #3001: HDDS-6206. Application errors must not flood system log

Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #3001:
URL: https://github.com/apache/ozone/pull/3001#issuecomment-1028608607


   Thanks @kuenishi for updating the patch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org