You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Kapil Arya <ka...@mesosphere.io> on 2017/04/28 18:54:11 UTC

Review Request 58763: Added volume/secret isolator.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58763/
-----------------------------------------------------------

Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.


Bugs: MESOS-7418
    https://issues.apache.org/jira/browse/MESOS-7418


Repository: mesos


Description
-------

This is still Work in Progress.


Diffs
-----

  src/Makefile.am 29da17bee13226e18757e2ad3a7a091427fd35f4 
  src/slave/containerizer/containerizer.hpp 4c31a1f5c853c1dc66480c7b4c867a87a1bb5c41 
  src/slave/containerizer/containerizer.cpp 9024371b6c4228f0903cfeef3bbec736e1a425f8 
  src/slave/containerizer/mesos/containerizer.hpp 29a99f33e646593127b9dc126f398f7bca88e21d 
  src/slave/containerizer/mesos/containerizer.cpp 56db7eb1193c9812b62b9149c9c2b2dd9b66701c 
  src/slave/containerizer/mesos/isolators/volume/secret.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/volume/secret.cpp PRE-CREATION 
  src/tests/cluster.hpp 65634121b7fe076a7cd9a1c5aa6101a96b1c009d 
  src/tests/cluster.cpp a4f57e0e9c4f221c42bdbb36d8925f688b3d742f 
  src/tests/mock_slave.hpp 767ed3d0444258f30b7338981ccc0080166ac5a7 
  src/tests/mock_slave.cpp c435ec76ac44775bf8a87421640649495c16187e 


Diff: https://reviews.apache.org/r/58763/diff/1/


Testing
-------


Thanks,

Kapil Arya

Re: Review Request 58763: Added volume/secret isolator.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58763/#review173416
-----------------------------------------------------------



Patch looks great!

Reviews applied: [58758, 58759, 58760, 58761, 58762, 58763]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On April 28, 2017, 6:54 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58763/
> -----------------------------------------------------------
> 
> (Updated April 28, 2017, 6:54 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-7418
>     https://issues.apache.org/jira/browse/MESOS-7418
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is still Work in Progress.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 29da17bee13226e18757e2ad3a7a091427fd35f4 
>   src/slave/containerizer/containerizer.hpp 4c31a1f5c853c1dc66480c7b4c867a87a1bb5c41 
>   src/slave/containerizer/containerizer.cpp 9024371b6c4228f0903cfeef3bbec736e1a425f8 
>   src/slave/containerizer/mesos/containerizer.hpp 29a99f33e646593127b9dc126f398f7bca88e21d 
>   src/slave/containerizer/mesos/containerizer.cpp 56db7eb1193c9812b62b9149c9c2b2dd9b66701c 
>   src/slave/containerizer/mesos/isolators/volume/secret.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/volume/secret.cpp PRE-CREATION 
>   src/tests/cluster.hpp 65634121b7fe076a7cd9a1c5aa6101a96b1c009d 
>   src/tests/cluster.cpp a4f57e0e9c4f221c42bdbb36d8925f688b3d742f 
>   src/tests/mock_slave.hpp 767ed3d0444258f30b7338981ccc0080166ac5a7 
>   src/tests/mock_slave.cpp c435ec76ac44775bf8a87421640649495c16187e 
> 
> 
> Diff: https://reviews.apache.org/r/58763/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>