[jira] Commented: (ZOOKEEPER-465) Ledger size in bytes

["Benjamin Reed (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12991266#comment-12991266 ] 

Benjamin Reed commented on ZOOKEEPER-465:
-----------------------------------------

sorry to be a pain flavio, but can i get a couple very minor changes?

1) in PendingReadOp can you comment what you substract 8 on the line:

{code}
+        entry.length = buffer.getLong(DigestManager.METADATA_LENGTH - 8);
{code}

2) in LedgerRecoveryOp can you comment on the line:

{code}
+            lh.length = entry.getLength() - (long) data.length;
{code}

i think it is because you are going to call add entry on that data, so it will be added back, right?

3) we have been focusing a bit on the info levels of log messages and i think the following message should be debug:

{code}
+            LOG.info("After closing length is: " + lh.getLength());
{code}  

> Ledger size in bytes
> --------------------
>
>                 Key: ZOOKEEPER-465
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-465
>             Project: ZooKeeper
>          Issue Type: New Feature
>          Components: contrib-bookkeeper
>            Reporter: Flavio Junqueira
>            Assignee: Flavio Junqueira
>             Fix For: 3.3.3, 3.4.0
>
>         Attachments: ZOOKEEPER-465.patch, ZOOKEEPER-465.patch, ZOOKEEPER-465.patch
>
>
> It is currently easy to know how many entries a ledger has, but there is no easy way to know the total number of bytes in a ledger. The idea of this jira is to add a method that gives the number of bytes in a closed ledger. My current idea is to simply have the writer counting the number of bytes written and store it to ZooKeeper.  

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira