[GitHub] [incubator-doris] chaoyli commented on a change in pull request #4964: [Bug][Compaction] Fix bug that output rowset is not deleted after compaction failure.

[GitBox <gi...@apache.org>]

chaoyli commented on a change in pull request #4964:
URL: https://github.com/apache/incubator-doris/pull/4964#discussion_r531494539



##########
File path: be/src/olap/compaction.cpp
##########
@@ -164,17 +173,11 @@ void Compaction::modify_rowsets() {
     _tablet->save_meta();
 }
 
-OLAPStatus Compaction::gc_unused_rowsets() {
+void Compaction::gc_output_rowset() {

Review comment:
       why not call gc_output_rowset in every succeed? It seems a new imported bug ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org