You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/08/25 01:07:45 UTC
[GitHub] [kafka] mjsax opened a new pull request #9217: MINOR: fix JavaDoc
mjsax opened a new pull request #9217:
URL: https://github.com/apache/kafka/pull/9217
Call for review @vvcephei
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mjsax commented on pull request #9217: MINOR: fix JavaDoc
Posted by GitBox <gi...@apache.org>.
mjsax commented on pull request #9217:
URL: https://github.com/apache/kafka/pull/9217#issuecomment-680310495
Retest this please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mjsax merged pull request #9217: MINOR: fix JavaDoc
Posted by GitBox <gi...@apache.org>.
mjsax merged pull request #9217:
URL: https://github.com/apache/kafka/pull/9217
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mjsax commented on a change in pull request #9217: MINOR: fix JavaDoc
Posted by GitBox <gi...@apache.org>.
mjsax commented on a change in pull request #9217:
URL: https://github.com/apache/kafka/pull/9217#discussion_r476026230
##########
File path: streams/src/main/java/org/apache/kafka/streams/processor/api/ProcessorContext.java
##########
@@ -106,7 +105,7 @@ void register(final StateStore store,
/**
* Schedules a periodic operation for processors. A processor may call this method during
- * {@link Processor#init(org.apache.kafka.streams.processor.ProcessorContext) initialization} or
+ * {@link Processor#init(ProcessorContext) initialization} or
Review comment:
Removing the package name to point to `org.apache.kafka.streams.processor.api.ProcessorContext` (note the `api` sub-package in the path)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mjsax commented on a change in pull request #9217: MINOR: fix JavaDoc
Posted by GitBox <gi...@apache.org>.
mjsax commented on a change in pull request #9217:
URL: https://github.com/apache/kafka/pull/9217#discussion_r476025687
##########
File path: streams/src/main/java/org/apache/kafka/streams/errors/StreamsNotStartedException.java
##########
@@ -17,11 +17,12 @@
package org.apache.kafka.streams.errors;
import org.apache.kafka.streams.KafkaStreams;
+import org.apache.kafka.streams.KafkaStreams.State;
/**
- * Indicates that Kafka Streams is in state {@link KafkaStreams.State#CREATED CREATED} and thus state stores cannot be queries yet.
+ * Indicates that Kafka Streams is in state {@link State CREATED} and thus state stores cannot be queries yet.
Review comment:
We can only link to the enum, but not its values.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] vvcephei commented on a change in pull request #9217: MINOR: fix JavaDoc
Posted by GitBox <gi...@apache.org>.
vvcephei commented on a change in pull request #9217:
URL: https://github.com/apache/kafka/pull/9217#discussion_r476754081
##########
File path: streams/src/main/java/org/apache/kafka/streams/processor/api/ProcessorContext.java
##########
@@ -106,7 +105,7 @@ void register(final StateStore store,
/**
* Schedules a periodic operation for processors. A processor may call this method during
- * {@link Processor#init(org.apache.kafka.streams.processor.ProcessorContext) initialization} or
+ * {@link Processor#init(ProcessorContext) initialization} or
Review comment:
Good catch.
##########
File path: streams/src/main/java/org/apache/kafka/streams/errors/StreamsNotStartedException.java
##########
@@ -17,11 +17,12 @@
package org.apache.kafka.streams.errors;
import org.apache.kafka.streams.KafkaStreams;
+import org.apache.kafka.streams.KafkaStreams.State;
/**
- * Indicates that Kafka Streams is in state {@link KafkaStreams.State#CREATED CREATED} and thus state stores cannot be queries yet.
+ * Indicates that Kafka Streams is in state {@link State CREATED} and thus state stores cannot be queries yet.
Review comment:
Ah!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mjsax closed pull request #9217: MINOR: fix JavaDoc
Posted by GitBox <gi...@apache.org>.
mjsax closed pull request #9217:
URL: https://github.com/apache/kafka/pull/9217
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org