You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2013/10/29 23:07:00 UTC
Review Request 15065: Fixed a pid comparison in the scheduler driver.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15065/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Repository: mesos-git
Description
-------
I couldn't figure out how this compiles! There does not appear to be a > operator for UPID.
Diffs
-----
src/sched/sched.cpp 3049096a7aeaea6c1063a1bbcef119517daa236c
Diff: https://reviews.apache.org/r/15065/diff/
Testing
-------
make check
Thanks,
Ben Mahler
Re: Review Request 15065: Fixed a pid comparison in the scheduler driver.
Posted by Jie Yu <yu...@gmail.com>.
> On Oct. 29, 2013, 10:35 p.m., Vinod Kone wrote:
> > It compiles because UPID has bool operator defined.
Probably we need to make it explicit once we have C++11:
http://en.wikipedia.org/wiki/C%2B%2B11#Explicit_conversion_operators
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15065/#review27738
-----------------------------------------------------------
On Oct. 29, 2013, 10:06 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15065/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2013, 10:06 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> I couldn't figure out how this compiles! There does not appear to be a > operator for UPID.
>
>
> Diffs
> -----
>
> src/sched/sched.cpp 3049096a7aeaea6c1063a1bbcef119517daa236c
>
> Diff: https://reviews.apache.org/r/15065/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 15065: Fixed a pid comparison in the scheduler driver.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15065/#review27738
-----------------------------------------------------------
Ship it!
It compiles because UPID has bool operator defined.
- Vinod Kone
On Oct. 29, 2013, 10:06 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15065/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2013, 10:06 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> I couldn't figure out how this compiles! There does not appear to be a > operator for UPID.
>
>
> Diffs
> -----
>
> src/sched/sched.cpp 3049096a7aeaea6c1063a1bbcef119517daa236c
>
> Diff: https://reviews.apache.org/r/15065/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>