[jira] [Closed] (THRIFT-1310) Generate PHP client code not check sequence ID in messages

["James E. King III (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/THRIFT-1310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

James E. King III closed THRIFT-1310.
-------------------------------------
    Resolution: Invalid
      Assignee: James E. King III

Thrift isn't a message bus - you have to remain connected to get the reply to your request. 
 Resolving as invalid.  When a disconnect occurs, all outstanding requests should be considered incomplete.  There's no way to get the reply if you disconnect.  

> Generate PHP client code not check sequence ID in messages
> ----------------------------------------------------------
>
>                 Key: THRIFT-1310
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1310
>             Project: Thrift
>          Issue Type: Bug
>          Components: PHP - Library
>    Affects Versions: 0.7
>            Reporter: Jian Fang
>            Assignee: James E. King III
>            Priority: Critical
>              Labels: security-issue
>         Attachments: t_php_generator.patch
>
>
> The PHP client code not check sequence ID in messages, when client connect timeout, the return of results are out of sequence. I try to fix this by throwing a exception when sequence ID not equal. Patch file is listed below.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)