You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Daniel Pravat <dp...@outlook.com> on 2017/01/10 19:01:38 UTC

Review Request 55388: Added `system` environment variables in `mesos-docker-executor`.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55388/
-----------------------------------------------------------

Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joseph Wu, and Michael Park.


Repository: mesos


Description
-------

Added `system` environment variables in `mesos-docker-executor`.


Diffs
-----

  src/slave/containerizer/docker.cpp 7a8a7271b54af0b4dcdae7a2aa8a90a8a7d05fd6 

Diff: https://reviews.apache.org/r/55388/diff/


Testing
-------


Thanks,

Daniel Pravat


Re: Review Request 55388: Added `system` environment variables in `mesos-docker-executor`.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55388/#review161118
-----------------------------------------------------------



Patch looks great!

Reviews applied: [55388]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 10, 2017, 7:01 p.m., Daniel Pravat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55388/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2017, 7:01 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joseph Wu, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added `system` environment variables in `mesos-docker-executor`.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/docker.cpp 7a8a7271b54af0b4dcdae7a2aa8a90a8a7d05fd6 
> 
> Diff: https://reviews.apache.org/r/55388/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>