You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@isis.apache.org by da...@apache.org on 2013/12/12 22:01:31 UTC

git commit: ISIS-632: fixing up lengths

Updated Branches:
  refs/heads/master 3364e7617 -> f54746f79


ISIS-632: fixing up lengths

... made silly mistake last time around.


Project: http://git-wip-us.apache.org/repos/asf/isis/repo
Commit: http://git-wip-us.apache.org/repos/asf/isis/commit/f54746f7
Tree: http://git-wip-us.apache.org/repos/asf/isis/tree/f54746f7
Diff: http://git-wip-us.apache.org/repos/asf/isis/diff/f54746f7

Branch: refs/heads/master
Commit: f54746f796975eca0ba5f8bfe4ccf30dc05349bb
Parents: 3364e76
Author: Dan Haywood <da...@apache.org>
Authored: Thu Dec 12 21:00:33 2013 +0000
Committer: Dan Haywood <da...@apache.org>
Committed: Thu Dec 12 21:00:33 2013 +0000

----------------------------------------------------------------------
 .../applib/service/publish/PublishedEvent.java  | 31 +++++++++++---------
 1 file changed, 17 insertions(+), 14 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/isis/blob/f54746f7/component/objectstore/jdo/jdo-applib/src/main/java/org/apache/isis/objectstore/jdo/applib/service/publish/PublishedEvent.java
----------------------------------------------------------------------
diff --git a/component/objectstore/jdo/jdo-applib/src/main/java/org/apache/isis/objectstore/jdo/applib/service/publish/PublishedEvent.java b/component/objectstore/jdo/jdo-applib/src/main/java/org/apache/isis/objectstore/jdo/applib/service/publish/PublishedEvent.java
index ecb08a6..4002383 100644
--- a/component/objectstore/jdo/jdo-applib/src/main/java/org/apache/isis/objectstore/jdo/applib/service/publish/PublishedEvent.java
+++ b/component/objectstore/jdo/jdo-applib/src/main/java/org/apache/isis/objectstore/jdo/applib/service/publish/PublishedEvent.java
@@ -28,7 +28,6 @@ import org.apache.isis.applib.annotation.ActionSemantics.Of;
 import org.apache.isis.applib.annotation.Bulk;
 import org.apache.isis.applib.annotation.Hidden;
 import org.apache.isis.applib.annotation.Immutable;
-import org.apache.isis.applib.annotation.Mandatory;
 import org.apache.isis.applib.annotation.MemberOrder;
 import org.apache.isis.applib.annotation.MultiLine;
 import org.apache.isis.applib.annotation.NotPersisted;
@@ -55,7 +54,7 @@ public class PublishedEvent {
 
     private String title;
 
-    @javax.jdo.annotations.Column(allowsNull="false", length=50)
+    @javax.jdo.annotations.Column(allowsNull="false", length=255)
     @Title
     @Hidden
     public String getTitle() {
@@ -83,7 +82,17 @@ public class PublishedEvent {
 
     private String id;
 
-    @javax.jdo.annotations.Column(length=40)
+    /**
+     * Programmatic because information also available in the {@link #getId() id}.
+     * 
+     * <p>
+     * Length of 47 because 36 chars (UUID) + 1 character + 10 chars for sequence number (an int) 
+     * 
+     * <p>
+     * @see EventMetadata#getId()
+     * @see https://issues.apache.org/jira/browse/ISIS-632
+     */
+    @javax.jdo.annotations.Column(length=47)
     @javax.jdo.annotations.PrimaryKey
     @MemberOrder(sequence = "2")
     public String getId() {
@@ -99,17 +108,9 @@ public class PublishedEvent {
     private String transactionId;
 
     /**
-     * Programmatic because information also available in the {@link #getId() id}.
-     * 
-     * <p>
-     * Length of 42 because 36 chars (UUID) + 1 character + 5 chars for sequence number (allowing up to 99,999 events 
-     * per Isis xactn).
-     * 
-     * <p>
-     * @see EventMetadata#getId()
-     * @see https://issues.apache.org/jira/browse/ISIS-632
+     * Hidden (<tt>@Programmatic</tt>) because information also available in the {@link #getId() id}.
      */
-    @javax.jdo.annotations.Column(length=42)
+    @javax.jdo.annotations.Column(length=36)
     @Programmatic
     public String getTransactionId() {
         return transactionId;
@@ -124,7 +125,9 @@ public class PublishedEvent {
     private int sequence;
 
     /**
-     * Programmatic because information also available in the {@link #getId() id}.
+     * Hidden (<tt>@Programmatic</tt>) because information also available in the {@link #getId() id}.
+     * 
+     * @see #getId()
      */
     @Programmatic
     public int getSequence() {