[jira] [Commented] (SAMOA-14) Disambiguate ARFFFileStream

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SAMOA-14?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15182133#comment-15182133 ] 

ASF GitHub Bot commented on SAMOA-14:
-------------------------------------

GitHub user gdfm opened a pull request:

    https://github.com/apache/incubator-samoa/pull/51

    SAMOA-14: Disambiguate ARFFFileStream

    Removed the old ARFFFileStream, and moved all the stream-related classed under org.apache.samoa.streams
    The new ARFFFileStream allows different sources for the file (e.g., local or HDFS):
    
    bin/samoa local target/SAMOA-Local-0.4.0-incubating-SNAPSHOT.jar "PrequentialEvaluation -s (ArffFileStream -s HDFSFileStreamSource -f /user/$USER/covtypeNorm.arff)"

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gdfm/incubator-samoa SAMOA-14

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-samoa/pull/51.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #51
    
----
commit 45f8317a37ed9a2758aae5dd0c9a317ef615abef
Author: Gianmarco De Francisci Morales <gd...@apache.org>
Date:   2016-03-06T12:22:37Z

    SAMOA-14: Consolidate ARFFFileStream

commit f261086e9b92db054d8a44da153066e2a01d9c90
Author: Gianmarco De Francisci Morales <gd...@apache.org>
Date:   2016-03-06T12:29:05Z

    SAMOA-14: Move all streams under single package

----


> Disambiguate ARFFFileStream
> ---------------------------
>
>                 Key: SAMOA-14
>                 URL: https://issues.apache.org/jira/browse/SAMOA-14
>             Project: SAMOA
>          Issue Type: Task
>          Components: SAMOA-API
>            Reporter: Suneel Marthi
>
> There are presently 2 ARFFFileStream classes
> {Code}
> com.yahoo.labs.samoa.streams.ARFFFileStream
> com.yahoo.labs.samoa.moa.streams.ARFFileStream
> {Code}
> Pasting here Gianmarco's comments:
> -----------------------------------------------------------
> At least one of the two is being used, even though not statically from the codebase. When you launch SAMOA from the command line, e.g.:
> bin/samoa local target/SAMOA-Local-0.0.1-SNAPSHOT.jar "PrequentialEvaluation -l classifiers.ensemble.Bagging -s (ArffFileStream -f covtypeNorm.arff) -f 100000"
> you are instantiating an InstanceStream (the -s option).
> Given that InstanceStream is in com.yahoo.labs.samoa.moa.streams, right now we are using com.yahoo.labs.samoa.moa.streams.ArffFileStream.
> However com.yahoo.labs.samoa.stream.ArffFileStream is the new one with the new class architecture. This ArffFileStream extends FileStream and should allow to read several file formats.
> So I guess we should keep only this latter one and make sure it works.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)