You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/04/17 20:19:43 UTC

[GitHub] [airflow] piffall commented on issue #4064: AIRFLOW-3149 Support dataproc cluster deletion on ERROR

piffall commented on issue #4064: AIRFLOW-3149 Support dataproc cluster deletion on ERROR
URL: https://github.com/apache/airflow/pull/4064#issuecomment-484245591
 
 
   > @OmerJog I went over that test in detail and it seems like the `with self.assertRaises(TypeError)` was a defensive measure to catch an exception within the test and not that raising a TypeError was part of the test specification. I've deleted that line to see if the rest of the test is successful.
   > 
   > cc @piffall who added that line about 11 months ago
   
   Hi @dossett, in fact, I didn't add that line, I just keep [that test with a minor change](https://github.com/apache/airflow/pull/3357/files#diff-f7804530ca88cb2e43e9492695ccde2cL320). 
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services