You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org> on 2022/04/14 16:24:16 UTC
[Impala-ASF-CR] IMPALA-11246: TestAcid.test lock timings is flaky
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18419
Change subject: IMPALA-11246: TestAcid.test_lock_timings is flaky
......................................................................
IMPALA-11246: TestAcid.test_lock_timings is flaky
Added a few extra seconds to the test_lock_timings test to
make it more stable.
Also added an extra log message about the time being spent
on waiting for the lock.
Change-Id: I4c9cc52f799261bbf610e7510e7bf1b61ca6c60a
---
M fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
M tests/query_test/test_acid.py
2 files changed, 11 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/19/18419/1
--
To view, visit http://gerrit.cloudera.org:8080/18419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4c9cc52f799261bbf610e7510e7bf1b61ca6c60a
Gerrit-Change-Number: 18419
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-11246: TestAcid.test lock timings is flaky
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18419 )
Change subject: IMPALA-11246: TestAcid.test_lock_timings is flaky
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8050/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/18419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4c9cc52f799261bbf610e7510e7bf1b61ca6c60a
Gerrit-Change-Number: 18419
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Apr 2022 18:37:20 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11246: TestAcid.test lock timings is flaky
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18419 )
Change subject: IMPALA-11246: TestAcid.test_lock_timings is flaky
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4c9cc52f799261bbf610e7510e7bf1b61ca6c60a
Gerrit-Change-Number: 18419
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Apr 2022 18:37:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11246: TestAcid.test lock timings is flaky
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18419 )
Change subject: IMPALA-11246: TestAcid.test_lock_timings is flaky
......................................................................
IMPALA-11246: TestAcid.test_lock_timings is flaky
Added a few extra seconds to the test_lock_timings test to
make it more stable.
Also added an extra log message about the time being spent
on waiting for the lock.
Change-Id: I4c9cc52f799261bbf610e7510e7bf1b61ca6c60a
Reviewed-on: http://gerrit.cloudera.org:8080/18419
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/catalog/Hive3MetastoreShimBase.java
M tests/query_test/test_acid.py
2 files changed, 11 insertions(+), 7 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/18419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4c9cc52f799261bbf610e7510e7bf1b61ca6c60a
Gerrit-Change-Number: 18419
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-11246: TestAcid.test lock timings is flaky
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18419 )
Change subject: IMPALA-11246: TestAcid.test_lock_timings is flaky
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4c9cc52f799261bbf610e7510e7bf1b61ca6c60a
Gerrit-Change-Number: 18419
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Apr 2022 18:18:34 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11246: TestAcid.test lock timings is flaky
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18419 )
Change subject: IMPALA-11246: TestAcid.test_lock_timings is flaky
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4c9cc52f799261bbf610e7510e7bf1b61ca6c60a
Gerrit-Change-Number: 18419
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Apr 2022 23:07:07 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11246: TestAcid.test lock timings is flaky
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18419 )
Change subject: IMPALA-11246: TestAcid.test_lock_timings is flaky
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10454/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18419
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4c9cc52f799261bbf610e7510e7bf1b61ca6c60a
Gerrit-Change-Number: 18419
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Apr 2022 16:43:50 +0000
Gerrit-HasComments: No