You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spamassassin.apache.org by qu...@apache.org on 2004/02/13 08:59:46 UTC

svn commit: rev 6636 - in incubator/spamassassin/trunk: lib/Mail/SpamAssassin rules

Author: quinlan
Date: Thu Feb 12 23:59:45 2004
New Revision: 6636

Modified:
   incubator/spamassassin/trunk/lib/Mail/SpamAssassin/HTML.pm
   incubator/spamassassin/trunk/rules/70_testing.cf
Log:
stop rendering ALT text since most mailers don't
add a test for excessively long ALT text (total length did not work well)


Modified: incubator/spamassassin/trunk/lib/Mail/SpamAssassin/HTML.pm
==============================================================================
--- incubator/spamassassin/trunk/lib/Mail/SpamAssassin/HTML.pm	(original)
+++ incubator/spamassassin/trunk/lib/Mail/SpamAssassin/HTML.pm	Thu Feb 12 23:59:45 2004
@@ -91,6 +91,7 @@
   $self->{html}{max_shouting} = 0;
   $self->{html}{total_comment_ratio} = 0;
   $self->{html}{title_index} = -1;
+  $self->{html}{alt_longest} = 0;
 
   $self->{html_text} = [];
   $self->{html_last_tag} = 0;
@@ -204,7 +205,9 @@
     push @{$self->{html_text}}, "\n\n";
   }
   elsif ($tag eq "img" && exists $attr->{alt} && $attr->{alt} ne "") {
-    push @{$self->{html_text}}, " $attr->{alt} ";
+    if (length($attr->{alt}) > $self->{html}{alt_longest}) {
+      $self->{html}{alt_longest} = length($attr->{alt});
+    }
   }
 }
 

Modified: incubator/spamassassin/trunk/rules/70_testing.cf
==============================================================================
--- incubator/spamassassin/trunk/rules/70_testing.cf	(original)
+++ incubator/spamassassin/trunk/rules/70_testing.cf	Thu Feb 12 23:59:45 2004
@@ -706,3 +706,21 @@
 
 body T_HTML_LINK_UNCLICKABLE	eval:html_test('anchor_unclickable')
 describe T_HTML_LINK_UNCLICKABLE	HTML link is not clickable
+
+# pick one
+body T_HTML_ALT_LONGEST_10	eval:html_eval('alt_longest', '> 10')
+body T_HTML_ALT_LONGEST_15	eval:html_eval('alt_longest', '> 15')
+body T_HTML_ALT_LONGEST_20	eval:html_eval('alt_longest', '> 20')
+body T_HTML_ALT_LONGEST_25	eval:html_eval('alt_longest', '> 25')
+body T_HTML_ALT_LONGEST_30	eval:html_eval('alt_longest', '> 30')
+body T_HTML_ALT_LONGEST_35	eval:html_eval('alt_longest', '> 35')
+body T_HTML_ALT_LONGEST_40	eval:html_eval('alt_longest', '> 40')
+body T_HTML_ALT_LONGEST_45	eval:html_eval('alt_longest', '> 45')
+body T_HTML_ALT_LONGEST_50	eval:html_eval('alt_longest', '> 50')
+body T_HTML_ALT_LONGEST_55	eval:html_eval('alt_longest', '> 55')
+body T_HTML_ALT_LONGEST_60	eval:html_eval('alt_longest', '> 60')
+body T_HTML_ALT_LONGEST_65	eval:html_eval('alt_longest', '> 65')
+body T_HTML_ALT_LONGEST_70	eval:html_eval('alt_longest', '> 70')
+body T_HTML_ALT_LONGEST_75	eval:html_eval('alt_longest', '> 75')
+body T_HTML_ALT_LONGEST_80	eval:html_eval('alt_longest', '> 80')
+body T_HTML_ALT_LONGEST_85	eval:html_eval('alt_longest', '> 85')