You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2021/07/13 07:09:50 UTC

[GitHub] [servicecomb-service-center] tianxiaoliang commented on a change in pull request #1093: Change: Modify schema without considering service environment

tianxiaoliang commented on a change in pull request #1093:
URL: https://github.com/apache/servicecomb-service-center/pull/1093#discussion_r668487111



##########
File path: datasource/etcd/ms.go
##########
@@ -45,6 +45,11 @@ import (
 	"github.com/apache/servicecomb-service-center/server/plugin/uuid"
 )
 
+var (
+	ErrUndefinedSchemaID    = pb.NewError(pb.ErrUndefinedSchemaID, datasource.ErrUndefinedSchemaID.Error())
+	ErrModifySchemaNotAllow = pb.NewError(pb.ErrModifySchemaNotAllow, datasource.ErrModifySchemaNotAllow.Error())

Review comment:
       是否提供个简单的NewFromError的API更方便




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org