You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2022/01/21 19:40:09 UTC
[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #6514: Fix traffic_portal audit issues and remove un-needed deps
ocket8888 commented on a change in pull request #6514:
URL: https://github.com/apache/trafficcontrol/pull/6514#discussion_r789946317
##########
File path: traffic_portal/package.json
##########
@@ -50,12 +41,12 @@
"angular-route": "1.8.0",
"angular-sanitize": "1.8.0",
"angular-ui-bootstrap": "0.14.3",
- "bootstrap-sass": "3.3.6",
- "es5-shim": "4.5.6",
+ "bootstrap-sass": "3.4.1",
+ "es5-shim": "4.6.4",
"flot": "2.3.2",
- "font-awesome": "4.5.0",
+ "font-awesome": "4.7.0",
"jquery": "3.6.0",
"jquery.flot.tooltip": "0.9.0",
- "json3": "3.3.2"
+ "json3": "3.3.3"
Review comment:
The description for the `json3` package on `npm` starts (after a deprecation notice) with the words _"JSON 3 **was**..."_ (emphasis mine), which is never a good sign. Neither is:
No major browser version since 2010 has not had support for `JSON` in the global scope ([source](https://caniuse.com/?search=JSON)) - again, predating the existence of Traffic Portal
##########
File path: traffic_portal/package.json
##########
@@ -50,12 +41,12 @@
"angular-route": "1.8.0",
"angular-sanitize": "1.8.0",
"angular-ui-bootstrap": "0.14.3",
- "bootstrap-sass": "3.3.6",
- "es5-shim": "4.5.6",
+ "bootstrap-sass": "3.4.1",
+ "es5-shim": "4.6.4",
Review comment:
Do we really need a shim for ES5? The only browser we truly support is Chrome, which added full support for ES5 70 major versions ago - which is a full decade behind us now, which in fact predates the very existence of this project. All other major browsers have full compliance as well ([source](https://caniuse.com/?search=es5)) with the exception of Opera Mini, which has an issue with `parseInt`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org