You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "cstamas (via GitHub)" <gi...@apache.org> on 2023/04/28 15:07:42 UTC
[GitHub] [maven-resolver] cstamas opened a new pull request, #285: [MRESOLVER-359] Make build be explicit about build time requirements
cstamas opened a new pull request, #285:
URL: https://github.com/apache/maven-resolver/pull/285
Fixes:
* make minimalMavenBuildVersion be "[3.8.4,)", we mean "recent" or maybe "maintained" Maven version.
* make minimalJavaBuildVersion be "[1.8.0-371,)" we mean "recent" Java 8.
---
https://issues.apache.org/jira/browse/MRESOLVER-359
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resolver] cstamas commented on a diff in pull request #285: [MRESOLVER-359] Make build be explicit about build time requirements
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on code in PR #285:
URL: https://github.com/apache/maven-resolver/pull/285#discussion_r1180731396
##########
pom.xml:
##########
@@ -93,7 +93,8 @@
<guavaVersion>30.1-jre</guavaVersion>
<guavafailureaccessVersion>1.0.1</guavafailureaccessVersion>
<slf4jVersion>1.7.36</slf4jVersion>
- <minimalMavenBuildVersion>3.8.4</minimalMavenBuildVersion>
+ <minimalMavenBuildVersion>[3.8.4,)</minimalMavenBuildVersion>
Review Comment:
Is not, see https://maven.apache.org/enforcer/enforcer-rules/versionRanges.html
"3.8.4" was "x >= 3.8.4 but 3.8.4 RECOMMENDED". This is not (semantically) what we _mean_.
What we mean is "use minimally 3.8.4 or ANY NEWER".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resolver] slawekjaranowski commented on a diff in pull request #285: [MRESOLVER-359] Make build be explicit about build time requirements
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #285:
URL: https://github.com/apache/maven-resolver/pull/285#discussion_r1180727977
##########
pom.xml:
##########
@@ -93,7 +93,8 @@
<guavaVersion>30.1-jre</guavaVersion>
<guavafailureaccessVersion>1.0.1</guavafailureaccessVersion>
<slf4jVersion>1.7.36</slf4jVersion>
- <minimalMavenBuildVersion>3.8.4</minimalMavenBuildVersion>
+ <minimalMavenBuildVersion>[3.8.4,)</minimalMavenBuildVersion>
+ <minimalJavaBuildVersion>[1.8.0-362,)</minimalJavaBuildVersion>
Review Comment:
Here can also be simple `1.8.0-362`
##########
pom.xml:
##########
@@ -93,7 +93,8 @@
<guavaVersion>30.1-jre</guavaVersion>
<guavafailureaccessVersion>1.0.1</guavafailureaccessVersion>
<slf4jVersion>1.7.36</slf4jVersion>
- <minimalMavenBuildVersion>3.8.4</minimalMavenBuildVersion>
+ <minimalMavenBuildVersion>[3.8.4,)</minimalMavenBuildVersion>
Review Comment:
It is exactly the same - what is the reason for such change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resolver] cstamas commented on a diff in pull request #285: [MRESOLVER-359] Make build be explicit about build time requirements
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on code in PR #285:
URL: https://github.com/apache/maven-resolver/pull/285#discussion_r1180733890
##########
pom.xml:
##########
@@ -93,7 +93,8 @@
<guavaVersion>30.1-jre</guavaVersion>
<guavafailureaccessVersion>1.0.1</guavafailureaccessVersion>
<slf4jVersion>1.7.36</slf4jVersion>
- <minimalMavenBuildVersion>3.8.4</minimalMavenBuildVersion>
+ <minimalMavenBuildVersion>[3.8.4,)</minimalMavenBuildVersion>
Review Comment:
Hm, wait a second... seems am wrong: "[enforcer] redefined as a minimum version.". So did I misinterpret then?
Still, I think if we provide (semantically) equivalent value, but in form of (maven and not "redefined enforcer") range, we are somehow clearer what we _really mean_ here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resolver] cstamas commented on a diff in pull request #285: [MRESOLVER-359] Make build be explicit about build time requirements
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on code in PR #285:
URL: https://github.com/apache/maven-resolver/pull/285#discussion_r1180731785
##########
pom.xml:
##########
@@ -93,7 +93,8 @@
<guavaVersion>30.1-jre</guavaVersion>
<guavafailureaccessVersion>1.0.1</guavafailureaccessVersion>
<slf4jVersion>1.7.36</slf4jVersion>
- <minimalMavenBuildVersion>3.8.4</minimalMavenBuildVersion>
+ <minimalMavenBuildVersion>[3.8.4,)</minimalMavenBuildVersion>
+ <minimalJavaBuildVersion>[1.8.0-362,)</minimalJavaBuildVersion>
Review Comment:
Same as above, 1.8.0-362 is NOT the recommended Java 8, just _minimal_ we allow to build with.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resolver] cstamas merged pull request #285: [MRESOLVER-359] Make build be explicit about build time requirements
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas merged PR #285:
URL: https://github.com/apache/maven-resolver/pull/285
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org