[GitHub] [bookkeeper] zymap commented on a diff in pull request #3889: [improve] [client] Group read/write response when jumping to the ordered executor

["zymap (via GitHub)" <gi...@apache.org>]

zymap commented on code in PR #3889:
URL: https://github.com/apache/bookkeeper/pull/3889#discussion_r1150250981


##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java:
##########
@@ -326,6 +332,7 @@ public class PerChannelBookieClient extends ChannelInboundHandlerAdapter {
     volatile Channel channel = null;
     private final ClientConnectionPeer connectionPeer;
     private volatile BookKeeperPrincipal authorizedId = BookKeeperPrincipal.ANONYMOUS;
+    private final BlockingQueue<BookieProtocol.Response> responses;

Review Comment:
   Maybe we can use BatchedArrayBlockingQueue? Then we can use takeAll() to get better performance.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org