You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by "rajat-garg-del (via GitHub)" <gi...@apache.org> on 2023/10/18 11:29:31 UTC

[PR] Add resize node function for azure driver [libcloud]

rajat-garg-del opened a new pull request, #1965:
URL: https://github.com/apache/libcloud/pull/1965

   ## Add resize node function for azure driver
   
   ### Description
   
   # Background
   
   https://github.com/apache/libcloud/issues/1964
   
   To start with we have def ex_change_node_size(self, node, new_size) function in [https://github.com/apache/libcloud/blob/trunk/libcloud/compute/drivers/ec2.py] which supports instance type change for AWS.
   
   We need similar functionality for Azure cloud as well where we could change the vmSize for Azure cloud. This could be done by adding node_resize function at (https://github.com/apache/libcloud/blob/trunk/libcloud/compute/drivers/azure_arm.py )
   
   # Implementation
   
   1. Added `ex_resize_node` to change the azure vm instance type.
   2. Added equivalent test `test_resize_node` to test `ex_resize_node` 
   
   ### Status
   - done, ready for review
   
   ### Checklist (tick everything that applies)
   
   - [ ] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks)
   - [ ] Documentation
   - [ ] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
   - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) (required for bigger changes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add resize node function for azure driver [libcloud]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #1965:
URL: https://github.com/apache/libcloud/pull/1965#issuecomment-1783862049

   We're currently processing your upload.  This comment will be updated when the results are available.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add resize node function for azure driver [libcloud]

Posted by "Kami (via GitHub)" <gi...@apache.org>.
Kami commented on PR #1965:
URL: https://github.com/apache/libcloud/pull/1965#issuecomment-1783866598

   Merged into trunk. Thanks for the contribution.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add resize node function for azure driver [libcloud]

Posted by "rajat-garg-del (via GitHub)" <gi...@apache.org>.
rajat-garg-del commented on PR #1965:
URL: https://github.com/apache/libcloud/pull/1965#issuecomment-1769965735

   @Kami Can u take a look into this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add resize node function for azure driver [libcloud]

Posted by "asfgit (via GitHub)" <gi...@apache.org>.
asfgit merged PR #1965:
URL: https://github.com/apache/libcloud/pull/1965


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org